subject:"\[Qemu\-devel\] \[PATCH 01\/19\] qapi\-commands.py\: Don't call the output marshal on error"

[Qemu-devel] [PATCH 01/19] qapi-commands.py: Don't call the output marshal on error

2011-10-27 Thread Luiz Capitulino

Today we generate something like this: int qmp_marshal_input_query_foo(...) ... retval = qmp_query_foo(errp); qmp_marshal_output_query_foo(retval, ret, errp); ... However, if qmp_query_foo() fails 'retval' will probably be NULL, which can cause a segfault

[Qemu-devel] [PATCH 01/19] qapi-commands.py: Don't call the output marshal on error

2011-10-24 Thread Luiz Capitulino

Today we generate something like this: int qmp_marshal_input_query_foo(...) ... retval = qmp_query_foo(errp); qmp_marshal_output_query_foo(retval, ret, errp); ... However, if qmp_query_foo() fails 'retval' will probably be NULL, which can cause a segfault