Re: [Qemu-devel] [PATCH 02/11] block: make write-threshold thread-safe

2017-07-10 Thread Stefan Hajnoczi
On Thu, Jul 06, 2017 at 06:38:19PM +0200, Paolo Bonzini wrote: > For simplicity, use bdrv_drained_begin/end to avoid concurrent > writes to the write threshold, or reading it while it is being set. > qmp_block_set_write_threshold is protected by the BQL. I find the commit message misleading: the

Re: [Qemu-devel] [PATCH 02/11] block: make write-threshold thread-safe

2017-07-06 Thread Eric Blake
On 07/06/2017 11:38 AM, Paolo Bonzini wrote: > For simplicity, use bdrv_drained_begin/end to avoid concurrent > writes to the write threshold, or reading it while it is being set. > qmp_block_set_write_threshold is protected by the BQL. > > Signed-off-by: Paolo Bonzini > ---

[Qemu-devel] [PATCH 02/11] block: make write-threshold thread-safe

2017-07-06 Thread Paolo Bonzini
For simplicity, use bdrv_drained_begin/end to avoid concurrent writes to the write threshold, or reading it while it is being set. qmp_block_set_write_threshold is protected by the BQL. Signed-off-by: Paolo Bonzini --- block/write-threshold.c | 9 +++-- 1 file changed,