Re: [Qemu-devel] [PATCH 02/12] char: add qemu_chr_fe_event()

2013-06-21 Thread Gerd Hoffmann
Hi, +static void spice_chr_fe_event(struct CharDriverState *chr, int event) +{ +#if SPICE_SERVER_VERSION = 0x000c02 +SpiceCharDriver *s = chr-opaque; + +spice_server_port_event(s-sin, event); +#endif +} No way. You are passing an qemu-internal value (event) to an external

Re: [Qemu-devel] [PATCH 02/12] char: add qemu_chr_fe_event()

2013-06-21 Thread Marc-André Lureau
On Fri, Jun 21, 2013 at 9:35 AM, Gerd Hoffmann kra...@redhat.com wrote: Hi, +static void spice_chr_fe_event(struct CharDriverState *chr, int event) +{ +#if SPICE_SERVER_VERSION = 0x000c02 +SpiceCharDriver *s = chr-opaque; + +spice_server_port_event(s-sin, event); +#endif

[Qemu-devel] [PATCH 02/12] char: add qemu_chr_fe_event()

2013-06-20 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- include/sysemu/char.h | 10 ++ qemu-char.c | 7 +++ spice-qemu-char.c | 10 ++ 3 files changed, 27 insertions(+) diff --git a/include/sysemu/char.h b/include/sysemu/char.h index 066c216..eee70fe