[Qemu-devel] [PATCH 03/19] General Support for VSX Helpers

2013-10-24 Thread Tom Musta
This patch adds general support that will be used by the VSX helper routines: - a union describing the various VSR subfields. - access routines to get and set VSRs - VSX decoders - a general routine to generate a handler that invokes a VSX helper. Signed-off-by: Tom Musta

Re: [Qemu-devel] [PATCH 03/19] General Support for VSX Helpers

2013-10-24 Thread Richard Henderson
On 10/24/2013 09:19 AM, Tom Musta wrote: +#define GEN_VSX_HELPER_2(name, op1, op2, inval, type) \ +static void gen_##name(DisasContext * ctx) \ +{ \ +

Re: [Qemu-devel] [PATCH 03/19] General Support for VSX Helpers

2013-10-24 Thread Tom Musta
On 10/24/2013 1:51 PM, Richard Henderson wrote: On 10/24/2013 09:19 AM, Tom Musta wrote: +#define GEN_VSX_HELPER_2(name, op1, op2, inval, type) \ +static void gen_##name(DisasContext * ctx)\ +{

Re: [Qemu-devel] [PATCH 03/19] General Support for VSX Helpers

2013-10-24 Thread Richard Henderson
On 10/24/2013 01:42 PM, Tom Musta wrote: Unless you are suggesting that the decoded VSR index (0..63) be passed to the helper? It was a thought. I'll leave the ultimate decision to ppc maintainers. The insns setting cr6 and crf[BF] get more complicated, but in general those could be handled