Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-04-03 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote: >> Il 21/03/2013 11:41, Laszlo Ersek ha scritto: >> > On 03/21/13 01:31, Laszlo Ersek wrote: >> >> On 03/21/13 00:45, Eric Blake wrote: >> >>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote: >> > >> +#

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-04-03 Thread Anthony Liguori
Paolo Bonzini writes: > Il 21/03/2013 13:42, Laszlo Ersek ha scritto: >> On 03/21/13 13:36, Michael S. Tsirkin wrote: >>> On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote: Il 21/03/2013 11:41, Laszlo Ersek ha scritto: > On 03/21/13 01:31, Laszlo Ersek wrote: >> On 03/21/

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 13:42, Laszlo Ersek ha scritto: > On 03/21/13 13:36, Michael S. Tsirkin wrote: >> On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote: >>> Il 21/03/2013 11:41, Laszlo Ersek ha scritto: On 03/21/13 01:31, Laszlo Ersek wrote: > On 03/21/13 00:45, Eric Blake wrote: >>>

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-21 Thread Laszlo Ersek
On 03/21/13 13:36, Michael S. Tsirkin wrote: > On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote: >> Il 21/03/2013 11:41, Laszlo Ersek ha scritto: >>> On 03/21/13 01:31, Laszlo Ersek wrote: On 03/21/13 00:45, Eric Blake wrote: > On 03/20/2013 05:23 PM, Laszlo Ersek wrote: >>> >

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote: > Il 21/03/2013 11:41, Laszlo Ersek ha scritto: > > On 03/21/13 01:31, Laszlo Ersek wrote: > >> On 03/21/13 00:45, Eric Blake wrote: > >>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote: > > > +# > +# @oem_id: #optional OEM ident

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 11:41, Laszlo Ersek ha scritto: > On 03/21/13 01:31, Laszlo Ersek wrote: >> On 03/21/13 00:45, Eric Blake wrote: >>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote: > +# +# @oem_id: #optional OEM identifier (6 bytes) >>> >>> s/oem_id/oem-id/ >>> >>> In general, new QMP interfac

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-21 Thread Laszlo Ersek
On 03/21/13 01:31, Laszlo Ersek wrote: > On 03/21/13 00:45, Eric Blake wrote: >> On 03/20/2013 05:23 PM, Laszlo Ersek wrote: >>> +# >>> +# @oem_id: #optional OEM identifier (6 bytes) >> >> s/oem_id/oem-id/ >> >> In general, new QMP interfaces should use '-', not '_'. > > Indeed! I think this warr

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-20 Thread Laszlo Ersek
On 03/21/13 00:45, Eric Blake wrote: > On 03/20/2013 05:23 PM, Laszlo Ersek wrote: >> Signed-off-by: Laszlo Ersek >> --- >> qapi-schema.json | 58 >> ++ > > No counterpart change to qmp-commands.hx showing a valid usage? This is not a qmp co

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-20 Thread Eric Blake
On 03/20/2013 05:23 PM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek > --- > qapi-schema.json | 58 > ++ No counterpart change to qmp-commands.hx showing a valid usage? > 1 files changed, 58 insertions(+), 0 deletions(-) > > diff --gi

[Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-20 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- qapi-schema.json | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index fdaa9da..aae6767 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3442