Re: [Qemu-devel] [PATCH 04/15] sheepdog: Mark sd_snapshot_delete() lossage FIXME

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > sd_snapshot_delete() should delete the snapshot whose ID matches > @snapshot_id and whose name matches @name. But that's not what it > does. If @snapshot_id is a valid ID, it deletes the snapshot with > that ID, else it deletes the snapshot with

[Qemu-devel] [PATCH 04/15] sheepdog: Mark sd_snapshot_delete() lossage FIXME

2017-03-02 Thread Markus Armbruster
sd_snapshot_delete() should delete the snapshot whose ID matches @snapshot_id and whose name matches @name. But that's not what it does. If @snapshot_id is a valid ID, it deletes the snapshot with that ID, else it deletes the snapshot with that name. It doesn't use @name at all. Add suitable