Re: [Qemu-devel] [PATCH 04/20] libqtest: Clean up how we read the QMP greeting

2018-07-15 Thread Markus Armbruster
Thomas Huth writes: > On 12.07.2018 13:12, Markus Armbruster wrote: >> qtest_init() still uses the qtest_qmp_discard_response(s, "") hack to >> receive the greeting, even though we have qtest_qmp_receive() since >> commit 66e0c7b187e. Put it to use. >> >> Bonus: gets rid of an empty format stri

Re: [Qemu-devel] [PATCH 04/20] libqtest: Clean up how we read the QMP greeting

2018-07-12 Thread Thomas Huth
On 12.07.2018 13:12, Markus Armbruster wrote: > qtest_init() still uses the qtest_qmp_discard_response(s, "") hack to > receive the greeting, even though we have qtest_qmp_receive() since > commit 66e0c7b187e. Put it to use. > > Bonus: gets rid of an empty format string. A step towards > compile

[Qemu-devel] [PATCH 04/20] libqtest: Clean up how we read the QMP greeting

2018-07-12 Thread Markus Armbruster
qtest_init() still uses the qtest_qmp_discard_response(s, "") hack to receive the greeting, even though we have qtest_qmp_receive() since commit 66e0c7b187e. Put it to use. Bonus: gets rid of an empty format string. A step towards compile-time format string checking without triggering -Wformat-z