Re: [Qemu-devel] [PATCH 05/15] sheepdog: Fix snapshot ID parsing in _open(), _create, _goto()

2017-03-03 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.03.2017 um 22:43 hat Markus Armbruster geschrieben: >> sd_parse_uri() and sd_snapshot_goto() screw up error checking after >> strtoul(), and truncate long tag names silently. Fix by replacing >> those parts by new sd_parse_snapid_or_tag(), which checks more >> carefull

Re: [Qemu-devel] [PATCH 05/15] sheepdog: Fix snapshot ID parsing in _open(), _create, _goto()

2017-03-03 Thread Kevin Wolf
Am 02.03.2017 um 22:43 hat Markus Armbruster geschrieben: > sd_parse_uri() and sd_snapshot_goto() screw up error checking after > strtoul(), and truncate long tag names silently. Fix by replacing > those parts by new sd_parse_snapid_or_tag(), which checks more > carefully. > > sd_snapshot_delete(

Re: [Qemu-devel] [PATCH 05/15] sheepdog: Fix snapshot ID parsing in _open(), _create, _goto()

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > sd_parse_uri() and sd_snapshot_goto() screw up error checking after > strtoul(), and truncate long tag names silently. Fix by replacing > those parts by new sd_parse_snapid_or_tag(), which checks more > carefully. At least we've fixed checkpatch

[Qemu-devel] [PATCH 05/15] sheepdog: Fix snapshot ID parsing in _open(), _create, _goto()

2017-03-02 Thread Markus Armbruster
sd_parse_uri() and sd_snapshot_goto() screw up error checking after strtoul(), and truncate long tag names silently. Fix by replacing those parts by new sd_parse_snapid_or_tag(), which checks more carefully. sd_snapshot_delete() also parses snapshot IDs, but is currently too broken for me to touc