[Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest

2011-07-19 Thread Kevin Wolf
From: Hannes Reinecke h...@suse.de 'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a driver-defined pointer 'hba_private'. This saves the lookup for driver handling several commands in parallel. 'tag' is still being

Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest

2011-07-19 Thread Anthony Liguori
On 07/19/2011 05:15 AM, Kevin Wolf wrote: From: Hannes Reineckeh...@suse.de 'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a driver-defined pointer 'hba_private'. This saves the lookup for driver handling several

Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest

2011-07-19 Thread Kevin Wolf
Am 19.07.2011 14:43, schrieb Anthony Liguori: On 07/19/2011 05:15 AM, Kevin Wolf wrote: From: Hannes Reineckeh...@suse.de 'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a driver-defined pointer 'hba_private'.

Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest

2011-07-19 Thread Benjamin Herrenschmidt
On Tue, 2011-07-19 at 15:06 +0200, Kevin Wolf wrote: Am 19.07.2011 14:43, schrieb Anthony Liguori: On 07/19/2011 05:15 AM, Kevin Wolf wrote: From: Hannes Reineckeh...@suse.de 'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by

Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest

2011-07-19 Thread Hannes Reinecke
On 07/19/2011 03:06 PM, Kevin Wolf wrote: Am 19.07.2011 14:43, schrieb Anthony Liguori: On 07/19/2011 05:15 AM, Kevin Wolf wrote: From: Hannes Reineckeh...@suse.de 'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a

Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest

2011-07-19 Thread Benjamin Herrenschmidt
On Tue, 2011-07-19 at 07:43 -0500, Anthony Liguori wrote: This breaks the build: make[1]: Nothing to be done for `all'. CCppc64-softmmu/spapr_vscsi.o /home/anthony/git/qemu/hw/spapr_vscsi.c: In function ‘vscsi_command_complete’: /home/anthony/git/qemu/hw/spapr_vscsi.c:535:34:

Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest

2011-07-19 Thread Kevin Wolf
Am 19.07.2011 15:26, schrieb Hannes Reinecke: On 07/19/2011 03:06 PM, Kevin Wolf wrote: Am 19.07.2011 14:43, schrieb Anthony Liguori: On 07/19/2011 05:15 AM, Kevin Wolf wrote: From: Hannes Reineckeh...@suse.de 'tag' is just an abstraction to identify the command from the driver. So we

Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest

2011-07-19 Thread David Gibson
On Tue, Jul 19, 2011 at 11:20:22PM +1000, Benjamin Herrenschmidt wrote: On Tue, 2011-07-19 at 07:43 -0500, Anthony Liguori wrote: This breaks the build: make[1]: Nothing to be done for `all'. CCppc64-softmmu/spapr_vscsi.o /home/anthony/git/qemu/hw/spapr_vscsi.c: In function