Re: [Qemu-devel] [PATCH 05/25] migration: avoid using error_is_set and thus relying on errp != NULL

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: The migration code is using errp to detect internal errors, this means that it relies on errp being non-NULL. Impact?

Re: [Qemu-devel] [PATCH 05/25] migration: avoid using error_is_set and thus relying on errp != NULL

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 15:36, Markus Armbruster ha scritto: The migration code is using errp to detect internal errors, this means that it relies on errp being non-NULL. Impact? None because so far our only QMP client is HMP and never passes a NULL Error **. But if we had others, it would make sure

Re: [Qemu-devel] [PATCH 05/25] migration: avoid using error_is_set and thus relying on errp != NULL

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 17/10/2012 15:36, Markus Armbruster ha scritto: The migration code is using errp to detect internal errors, this means that it relies on errp being non-NULL. Impact? None because so far our only QMP client is HMP and never passes a NULL Error

[Qemu-devel] [PATCH 05/25] migration: avoid using error_is_set and thus relying on errp != NULL

2012-10-10 Thread Paolo Bonzini
The migration code is using errp to detect internal errors, this means that it relies on errp being non-NULL. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v1-v2: changed summary line of the commit message migration-tcp.c | 8 +--- migration.c | 13 +++-- 2 file