Re: [Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include

2017-06-09 Thread Philippe Mathieu-Daudé
On 05/23/2017 11:58 AM, Michael Tokarev wrote: 09.05.2017 02:39, Philippe Mathieu-Daudé wrote: "exec/memory.h" already includes it. I think this sort of include cleanups isn't really necessary. Some are useful ;) For a regular include file, it's better to include it if the .c file in

Re: [Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include

2017-05-23 Thread Michael Tokarev
09.05.2017 02:39, Philippe Mathieu-Daudé wrote: > "exec/memory.h" already includes it. I think this sort of include cleanups isn't really necessary. For a regular include file, it's better to include it if the .c file in question uses definitions from there, no matter if other .h files include

[Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include

2017-05-08 Thread Philippe Mathieu-Daudé
"exec/memory.h" already includes it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/arm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h index a3f79d3379..b9c11d3fb8 100644 --- a/include/hw/arm/arm.h +++