Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 12:05 AM, Michael S. Tsirkin wrote: On Wed, Jul 18, 2018 at 04:46:21PM +0800, Xiao Guangrong wrote: On 07/17/2018 02:58 AM, Dr. David Alan Gilbert wrote: * Xiao Guangrong (guangrong.x...@gmail.com) wrote: On 06/29/2018 05:42 PM, Dr. David Alan Gilbert wrote: * Xiao

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-07-22 Thread Michael S. Tsirkin
On Wed, Jul 18, 2018 at 04:46:21PM +0800, Xiao Guangrong wrote: > > > On 07/17/2018 02:58 AM, Dr. David Alan Gilbert wrote: > > * Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > > > > > > > On 06/29/2018 05:42 PM, Dr. David Alan Gilbert wrote: > > > > * Xiao Guangrong

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-07-18 Thread Xiao Guangrong
On 07/17/2018 02:58 AM, Dr. David Alan Gilbert wrote: * Xiao Guangrong (guangrong.x...@gmail.com) wrote: On 06/29/2018 05:42 PM, Dr. David Alan Gilbert wrote: * Xiao Guangrong (guangrong.x...@gmail.com) wrote: Hi Peter, Sorry for the delay as i was busy on other things. On 06/19/2018

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-07-16 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 06/29/2018 05:42 PM, Dr. David Alan Gilbert wrote: > > * Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > > > > Hi Peter, > > > > > > Sorry for the delay as i was busy on other things. > > > > > > On 06/19/2018 03:30 PM, Peter

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-07-02 Thread Xiao Guangrong
On 06/29/2018 05:42 PM, Dr. David Alan Gilbert wrote: * Xiao Guangrong (guangrong.x...@gmail.com) wrote: Hi Peter, Sorry for the delay as i was busy on other things. On 06/19/2018 03:30 PM, Peter Xu wrote: On Mon, Jun 04, 2018 at 05:55:14PM +0800, guangrong.x...@gmail.com wrote: From:

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-06-29 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Jun 28, 2018 at 05:12:39PM +0800, Xiao Guangrong wrote: > > > > Hi Peter, > > > > Sorry for the delay as i was busy on other things. > > > > On 06/19/2018 03:30 PM, Peter Xu wrote: > > > On Mon, Jun 04, 2018 at 05:55:14PM +0800,

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-06-29 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > Hi Peter, > > Sorry for the delay as i was busy on other things. > > On 06/19/2018 03:30 PM, Peter Xu wrote: > > On Mon, Jun 04, 2018 at 05:55:14PM +0800, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > Detecting

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-06-28 Thread Xiao Guangrong
Hi Daniel, On 06/28/2018 05:36 PM, Daniel P. Berrangé wrote: On Thu, Jun 28, 2018 at 05:12:39PM +0800, Xiao Guangrong wrote: After this patch, the workload is moved to the worker thread, is it acceptable? It depends on your point of view. If you have spare / idle CPUs on the host, then

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-06-28 Thread Daniel P . Berrangé
On Thu, Jun 28, 2018 at 05:12:39PM +0800, Xiao Guangrong wrote: > > Hi Peter, > > Sorry for the delay as i was busy on other things. > > On 06/19/2018 03:30 PM, Peter Xu wrote: > > On Mon, Jun 04, 2018 at 05:55:14PM +0800, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > >

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-06-28 Thread Xiao Guangrong
Hi Peter, Sorry for the delay as i was busy on other things. On 06/19/2018 03:30 PM, Peter Xu wrote: On Mon, Jun 04, 2018 at 05:55:14PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong Detecting zero page is not a light work, we can disable it for compression that can handle

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-06-19 Thread Peter Xu
On Mon, Jun 04, 2018 at 05:55:14PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Detecting zero page is not a light work, we can disable it > for compression that can handle all zero data very well Is there any number shows how the compression algo performs better than the

[Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-06-04 Thread guangrong . xiao
From: Xiao Guangrong Detecting zero page is not a light work, we can disable it for compression that can handle all zero data very well Signed-off-by: Xiao Guangrong --- migration/ram.c | 44 +++- 1 file changed, 23 insertions(+), 21 deletions(-) diff