[Qemu-devel] [PATCH 06/14] scsi: change removable field to host many features

2012-05-04 Thread Paolo Bonzini
It is pointless to add a uint32_t field for every new feature. Since we will need a new feature soon, convert accesses to removable to look at bit 0 only. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c | 23 +++ 1 file changed, 15 insertions(+), 8

Re: [Qemu-devel] [PATCH 06/14] scsi: change removable field to host many features

2012-05-04 Thread Stefan Weil
Am 04.05.2012 10:45, schrieb Paolo Bonzini: It is pointless to add a uint32_t field for every new feature. Since we will need a new feature soon, convert accesses to removable to look at bit 0 only. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- hw/scsi-disk.c | 23

Re: [Qemu-devel] [PATCH 06/14] scsi: change removable field to host many features

2012-05-04 Thread Paolo Bonzini
Il 04/05/2012 18:30, Stefan Weil ha scritto: +#define SCSI_DISK_F_REMOVABLE0 + ERROR: code indent should never use tabs #23: FILE: hw/scsi-disk.c:64: +#define SCSI_DISK_F_REMOVABLE^I0$ total: 1 errors, 0 warnings, 74 lines checked Not code indent. $ git grep $'^#.*define.*\t' --

Re: [Qemu-devel] [PATCH 06/14] scsi: change removable field to host many features

2012-05-04 Thread Andreas Färber
Am 04.05.2012 18:36, schrieb Paolo Bonzini: Il 04/05/2012 18:30, Stefan Weil ha scritto: +#define SCSI_DISK_F_REMOVABLE0 + ERROR: code indent should never use tabs #23: FILE: hw/scsi-disk.c:64: +#define SCSI_DISK_F_REMOVABLE^I0$ total: 1 errors, 0 warnings, 74 lines checked Not