Re: [Qemu-devel] [PATCH 06/17] blockdev: Pass QDict to blockdev_init()

2013-09-24 Thread Fam Zheng
On Fri, 09/20 13:54, Kevin Wolf wrote: > Working on a QDict instead of a QemuOpts that accepts anything is more > in line with bdrv_open(). A QDict is what qmp_blockdev_add() already has > anyway, so this saves additional conversions. And last, but not least, > it allows later patches to easily ext

Re: [Qemu-devel] [PATCH 06/17] blockdev: Pass QDict to blockdev_init()

2013-09-20 Thread Benoît Canet
Le Friday 20 Sep 2013 à 13:54:19 (+0200), Kevin Wolf a écrit : > Working on a QDict instead of a QemuOpts that accepts anything is more > in line with bdrv_open(). A QDict is what qmp_blockdev_add() already has > anyway, so this saves additional conversions. And last, but not least, > it allows lat

[Qemu-devel] [PATCH 06/17] blockdev: Pass QDict to blockdev_init()

2013-09-20 Thread Kevin Wolf
Working on a QDict instead of a QemuOpts that accepts anything is more in line with bdrv_open(). A QDict is what qmp_blockdev_add() already has anyway, so this saves additional conversions. And last, but not least, it allows later patches to easily extract legacy options into a separate, typed Qemu