Re: [Qemu-devel] [PATCH 06/19] block: Avoid unnecessary aio_poll() in AIO_WAIT_WHILE()

2018-04-11 Thread Su Hang
Dear Kevin: I notice checkpatch.pl complained about code style problems, you may want to replace `while (aio_poll(bs->aio_context, false));` with ``` while (aio_poll(bs->aio_context, false)) { /* No further work */ } ``` to suppress the complaints. Best, Su Hang "Kevin Wolf" wrote: > Commit 9

[Qemu-devel] [PATCH 06/19] block: Avoid unnecessary aio_poll() in AIO_WAIT_WHILE()

2018-04-11 Thread Kevin Wolf
Commit 91af091f923 added an additional aio_poll() to BDRV_POLL_WHILE() in order to make sure that all pending BHs are executed on drain. This was the wrong place to make the fix, as it is useless overhead for all other users of the macro and unnecessarily complicates the mechanism. This patch effe