Re: [Qemu-devel] [PATCH 06/28] trace: Eliminate use of TARGET_FMT_plx

2019-07-26 Thread Philippe Mathieu-Daudé
On 7/26/19 2:05 PM, Markus Armbruster wrote: > hw/tpm/trace-events uses TARGET_FMT_plx formats with uint64_t > arguments. That's wrong, TARGET_FMT_plx takes hwaddr. Since hwaddr > happens to be uint64_t, it works anyway. Messed up in commit > ec427498da5, v2.12.0. Clean up by replacing TARGET_F

[Qemu-devel] [PATCH 06/28] trace: Eliminate use of TARGET_FMT_plx

2019-07-26 Thread Markus Armbruster
hw/tpm/trace-events uses TARGET_FMT_plx formats with uint64_t arguments. That's wrong, TARGET_FMT_plx takes hwaddr. Since hwaddr happens to be uint64_t, it works anyway. Messed up in commit ec427498da5, v2.12.0. Clean up by replacing TARGET_FMT_plx with its macro expansion. scripts/tracetool/f