Re: [Qemu-devel] [PATCH 07/31] 9pfs: Fix CLI parsing crash on error

2018-10-09 Thread Greg Kurz
On Mon, 8 Oct 2018 19:31:01 +0200 Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. 9p-handle.c's handle_parse_opts() does that, and then > fails without setting an error. Wrong. Its caller crashes when it > tries to report the

[Qemu-devel] [PATCH 07/31] 9pfs: Fix CLI parsing crash on error

2018-10-08 Thread Markus Armbruster
Calling error_report() in a function that takes an Error ** argument is suspicious. 9p-handle.c's handle_parse_opts() does that, and then fails without setting an error. Wrong. Its caller crashes when it tries to report the error: $ qemu-system-x86_64 -nodefaults -fsdev