Re: [Qemu-devel] [PATCH 08/10] qapi: add strict mode to input visitor

2012-04-02 Thread Laurent Desnogues
Hello, On Thu, Mar 22, 2012 at 12:51 PM, Paolo Bonzini pbonz...@redhat.com wrote: While QMP in general is designed so that it is possible to ignore unknown arguments, in the case of the QMP server it is better to reject them to detect bad clients.  In fact, we're already doing this at the top

Re: [Qemu-devel] [PATCH 08/10] qapi: add strict mode to input visitor

2012-04-02 Thread Paolo Bonzini
Il 02/04/2012 12:34, Laurent Desnogues ha scritto: static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp) { +GHashTableIter iter; GHashTableIter is alas not available in the glib (2.12) that the distros we use at work run. Is there a workaround for this issue? Yeah, since

[Qemu-devel] [PATCH 08/10] qapi: add strict mode to input visitor

2012-03-22 Thread Paolo Bonzini
While QMP in general is designed so that it is possible to ignore unknown arguments, in the case of the QMP server it is better to reject them to detect bad clients. In fact, we're already doing this at the top level in the argument checker. To extend this to complex structures, add a mode to

Re: [Qemu-devel] [PATCH 08/10] qapi: add strict mode to input visitor

2012-03-22 Thread Anthony Liguori
On 03/22/2012 06:51 AM, Paolo Bonzini wrote: While QMP in general is designed so that it is possible to ignore unknown arguments, in the case of the QMP server it is better to reject them to detect bad clients. In fact, we're already doing this at the top level in the argument checker. To