Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

On Wed, Jul 6, 2016 at 3:40 PM, Marc-André Lureau wrote: > Hi > > On Tue, Jul 5, 2016 at 1:12 PM, Michael S. Tsirkin wrote: >> On Tue, Jul 05, 2016 at 11:18:38AM +0200, Marc-André Lureau wrote: >>> Hi >>> >>> On Tue, Jul 5, 2016 at 12:35 AM, Michael

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

Hi On Tue, Jul 5, 2016 at 1:12 PM, Michael S. Tsirkin wrote: > On Tue, Jul 05, 2016 at 11:18:38AM +0200, Marc-André Lureau wrote: >> Hi >> >> On Tue, Jul 5, 2016 at 12:35 AM, Michael S. Tsirkin wrote: >> > On Mon, Jul 04, 2016 at 11:56:56PM +0200, Marc-André

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

On Tue, Jul 05, 2016 at 11:18:38AM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Jul 5, 2016 at 12:35 AM, Michael S. Tsirkin wrote: > > On Mon, Jul 04, 2016 at 11:56:56PM +0200, Marc-André Lureau wrote: > >> Hi > >> > >> On Mon, Jul 4, 2016 at 5:47 PM, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

Hi On Tue, Jul 5, 2016 at 12:35 AM, Michael S. Tsirkin wrote: > On Mon, Jul 04, 2016 at 11:56:56PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Mon, Jul 4, 2016 at 5:47 PM, Michael S. Tsirkin wrote: >> > Why does vhost_user_set_log_base need to return error?

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

On Mon, Jul 04, 2016 at 11:56:56PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Jul 4, 2016 at 5:47 PM, Michael S. Tsirkin wrote: > > Why does vhost_user_set_log_base need to return error? > > If backend is not there to handle this message, > > then it is not changing memory

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

Hi On Mon, Jul 4, 2016 at 5:47 PM, Michael S. Tsirkin wrote: > Why does vhost_user_set_log_base need to return error? > If backend is not there to handle this message, > then it is not changing memory so it's ok to ignore the error. How do you know it's not changing the memory?

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

On Fri, Jun 24, 2016 at 02:46:28PM +0200, Marc-André Lureau wrote: > Hi > > On Thu, Jun 23, 2016 at 7:03 PM, Michael S. Tsirkin wrote: > >> > why bother? So callers can just ignore them in turn? > >> > >> The callers do not always ignore errors, fortunately (see > >>

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

Hi On Thu, Jun 23, 2016 at 7:03 PM, Michael S. Tsirkin wrote: >> > why bother? So callers can just ignore them in turn? >> >> The callers do not always ignore errors, fortunately (see >> vhost_user_init() for ex). > > But that doesn't call set log base, right? No, what is the

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

On Thu, Jun 23, 2016 at 05:14:04AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Tue, Jun 21, 2016 at 12:02:36PM +0200, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Return read errors (not sure why those

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

Hi - Original Message - > On Tue, Jun 21, 2016 at 12:02:36PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Return read errors (not sure why those were ignored) > > > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

On Tue, Jun 21, 2016 at 12:02:36PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Return read errors (not sure why those were ignored) > > Signed-off-by: Marc-André Lureau why bother? So callers can just

[Qemu-devel] [PATCH 08/24] vhost-user: return a read error

From: Marc-André Lureau Return read errors (not sure why those were ignored) Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost-user.c