Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn

2017-07-05 Thread Paolo Bonzini
On 05/07/2017 18:40, Marc-André Lureau wrote: > Hi > > - Original Message - >> >> >> On 05/07/2017 18:06, Marc-André Lureau wrote: > coroutine_fn too) It's not controversial, I would not have expected the functions to call coroutine_fn. :) How do they do that? >>>

Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn

2017-07-05 Thread Marc-André Lureau
Hi - Original Message - > > > On 05/07/2017 18:06, Marc-André Lureau wrote: > >>> coroutine_fn too) > >> It's not controversial, I would not have expected the functions to call > >> coroutine_fn. :) How do they do that? > >> > > For example, null_co_readv() calls null_co_common()

Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn

2017-07-05 Thread Paolo Bonzini
On 05/07/2017 18:06, Marc-André Lureau wrote: >>> coroutine_fn too) >> It's not controversial, I would not have expected the functions to call >> coroutine_fn. :) How do they do that? >> > For example, null_co_readv() calls null_co_common() which calls > co_aio_sleep_ns() But these are

Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn

2017-07-05 Thread Marc-André Lureau
Hi - Original Message - > > > On 05/07/2017 16:21, Marc-André Lureau wrote: > >> > >> They are, but it's an implementation detail. Why is this patch necessary? > > I didn't think this would be controversial :) well, the checks I added to > > clang verify function pointer share the

Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn

2017-07-05 Thread Paolo Bonzini
On 05/07/2017 16:21, Marc-André Lureau wrote: >> >> They are, but it's an implementation detail. Why is this patch necessary? > I didn't think this would be controversial :) well, the checks I added to > clang verify function pointer share the coroutine attribute. > > The function themself

Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn

2017-07-05 Thread Marc-André Lureau
- Original Message - > On 05/07/2017 00:03, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > include/block/block_int.h | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git

Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn

2017-07-05 Thread Paolo Bonzini
On 05/07/2017 00:03, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/block/block_int.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/block/block_int.h b/include/block/block_int.h > index

[Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn

2017-07-04 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- include/block/block_int.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/block/block_int.h b/include/block/block_int.h index 15fa602150..93eb2a9528 100644 --- a/include/block/block_int.h +++