Re: [Qemu-devel] [PATCH 1/1] mirror: restore offset after zeroing out the image

2017-01-31 Thread Anton Nefedov
On 01/30/2017 08:33 PM, Denis V. Lunev wrote: On 01/30/2017 08:16 PM, Eric Blake wrote: On 01/30/2017 04:22 AM, Denis V. Lunev wrote: If explicit zeroing out before mirroring is required for the target image, it moves the block job offset counter to EOF, then offset and len counters count the i

Re: [Qemu-devel] [PATCH 1/1] mirror: restore offset after zeroing out the image

2017-01-30 Thread Denis V. Lunev
On 01/30/2017 08:16 PM, Eric Blake wrote: > On 01/30/2017 04:22 AM, Denis V. Lunev wrote: >> If explicit zeroing out before mirroring is required for the target image, >> it moves the block job offset counter to EOF, then offset and len counters >> count the image size twice. >> >> There is no harm

Re: [Qemu-devel] [PATCH 1/1] mirror: restore offset after zeroing out the image

2017-01-30 Thread Eric Blake
On 01/30/2017 04:22 AM, Denis V. Lunev wrote: > If explicit zeroing out before mirroring is required for the target image, > it moves the block job offset counter to EOF, then offset and len counters > count the image size twice. > > There is no harm but confusing stats (e.g. for 1G image the comp

[Qemu-devel] [PATCH 1/1] mirror: restore offset after zeroing out the image

2017-01-30 Thread Denis V. Lunev
If explicit zeroing out before mirroring is required for the target image, it moves the block job offset counter to EOF, then offset and len counters count the image size twice. There is no harm but confusing stats (e.g. for 1G image the completion counter starts from 1G and increases to 2G) The