Re: [Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-27 Thread Li Zhang
Hi Andreas, I send out this patch with vga enablement on papr, which needs usb enabled. Is there any more suggestion about this patch? Who else need to ack it? Thank you very much. :) On Mon, Jun 18, 2012 at 5:22 PM, Li Zhang zhlci...@gmail.com wrote: For pseries machine, it needs to enable

Re: [Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-27 Thread Andreas Färber
Am 18.06.2012 11:22, schrieb Li Zhang: For pseries machine, it needs to enable usb to add keyboard or usb mouse. -usb option won't be used in the future, and machine options is a better way to enable usb. So this patch is to add usb option to machine options (-machine

Re: [Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-27 Thread Li Zhang
On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber afaer...@suse.de wrote: Am 18.06.2012 11:22, schrieb Li Zhang: For pseries machine, it needs to enable usb to add keyboard or usb mouse. -usb option won't be used in the future, and machine options is a better way to enable usb. So this patch

Re: [Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-27 Thread Peter Crosthwaite
On Wed, Jun 27, 2012 at 11:13 PM, Li Zhang zhlci...@gmail.com wrote: On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber afaer...@suse.de wrote: Am 18.06.2012 11:22, schrieb Li Zhang: For pseries machine, it needs to enable usb to add keyboard or usb mouse. -usb option won't be used in Grammar:

Re: [Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-27 Thread Andreas Färber
Am 27.06.2012 15:13, schrieb Li Zhang: On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber afaer...@suse.de wrote: Am 18.06.2012 11:22, schrieb Li Zhang: +bool usb_on = false; Didn't you want this to be true for sPAPR in absence of -machine? It is set in the following: if

Re: [Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-27 Thread Li Zhang
On Wed, Jun 27, 2012 at 9:22 PM, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: On Wed, Jun 27, 2012 at 11:13 PM, Li Zhang zhlci...@gmail.com wrote: On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber afaer...@suse.de wrote: Am 18.06.2012 11:22, schrieb Li Zhang: For pseries machine, it

Re: [Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-27 Thread Li Zhang
On Wed, Jun 27, 2012 at 9:24 PM, Andreas Färber afaer...@suse.de wrote: Am 27.06.2012 15:13, schrieb Li Zhang: On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber afaer...@suse.de wrote: Am 18.06.2012 11:22, schrieb Li Zhang: +    bool usb_on = false; Didn't you want this to be true for sPAPR in

[Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Li Zhang
For pseries machine, it needs to enable usb to add keyboard or usb mouse. -usb option won't be used in the future, and machine options is a better way to enable usb. So this patch is to add usb option to machine options (-machine type=psereis,usb=on/off)to enable/disable usb controller. For

Re: [Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Wei-Ren Chen
Hi Li Zhang, Perhaps you miss [PATCH v3 1/2] in the subject? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj