Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Jes Sorensen
On 02/03/11 18:41, Michael Roth wrote: On 02/02/2011 02:48 AM, Jes Sorensen wrote: Yes very much so[1] - one reason why it would be nice to have virtagent use threads to execute the actual commands. We should probably add a flag to agent commands indicating whether they issue disk I/O or not,

[Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed. - fsfreeze(): Walk the list of mounted local real file systems, and freeze them. -

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Michael Roth
On 02/04/2011 12:13 AM, Stefan Hajnoczi wrote: On Thu, Feb 3, 2011 at 5:41 PM, Michael Rothmdr...@linux.vnet.ibm.com wrote: For things like logging and i/o on a frozen system...I agree we'd need some flag for these kinds of situations. Maybe a disable_logging() flagi really don't like this

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Michael Roth
On 02/04/2011 05:03 AM, Jes Sorensen wrote: On 02/03/11 18:41, Michael Roth wrote: On 02/02/2011 02:48 AM, Jes Sorensen wrote: Yes very much so[1] - one reason why it would be nice to have virtagent use threads to execute the actual commands. We should probably add a flag to agent commands

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Stefan Hajnoczi
On Fri, Feb 4, 2011 at 4:27 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: Aborting an RPC handler could leave the system in an inconsistent state unless we are careful.  For example, aborting freeze requires thawing those file systems that have been successfully frozen so far. For other

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-03 Thread Michael Roth
On 02/02/2011 02:48 AM, Jes Sorensen wrote: On 02/02/11 08:57, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 10:58 AM,jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-03 Thread Stefan Hajnoczi
On Thu, Feb 3, 2011 at 5:41 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: For things like logging and i/o on a frozen system...I agree we'd need some flag for these kinds of situations. Maybe a disable_logging() flagi really don't like this though... I'd imagine even syslogd() could

[Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-02 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed. - fsfreeze(): Walk the list of mounted local real file systems, and freeze them. -

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-02 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 10:58 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed.  - fsfreeze(): Walk the list of

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-02 Thread Jes Sorensen
On 02/02/11 08:57, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 10:58 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is

[Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed. - fsfreeze(): Walk the list of mounted local real file systems, and freeze them. -

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 10:58 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed.  - fsfreeze(): Walk the list of

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Jes Sorensen
On 02/01/11 15:12, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 10:58 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen jes.soren...@redhat.com wrote: On 02/01/11 15:12, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 10:58 AM,  jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Implement freeze/thaw support in the guest, allowing the host to

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Jes Sorensen
On 02/01/11 15:34, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen jes.soren...@redhat.com wrote: I have to admit you lost me here, where do you get that 500ms time from? Is that the XMLRPC polling time or? I just used the example code from other agent calls. 500 ms is

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 2:36 PM, Jes Sorensen jes.soren...@redhat.com wrote: On 02/01/11 15:34, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen jes.soren...@redhat.com wrote: I have to admit you lost me here, where do you get that 500ms time from? Is that the XMLRPC polling

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Michael Roth
On 02/01/2011 08:41 AM, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 2:36 PM, Jes Sorensenjes.soren...@redhat.com wrote: On 02/01/11 15:34, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensenjes.soren...@redhat.com wrote: I have to admit you lost me here, where do you get