Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-27 Thread Alexandre Raymond
There are many more object files that are built conditionally.  Why is it okay not to delete them? Perhaps they should be deleted too... The GNU Make manual says the following about distclean: http://www.gnu.org/s/hello/manual/make/Standard-Targets.html Delete all files in the current

Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-26 Thread Markus Armbruster
Alexandre Raymond cerb...@gmail.com writes: At the moment, make distclean relies on the TARGET_DIRS variable, set by configure. The problem is that this variable does not always contain all possible targets. For example, the following will leave build data in the tree: ./configure make

Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-26 Thread Alexandre Raymond
Hi Markus, Well, I'd expect distclean to remove exactly what *this* makefile can build, and leave everything else alone. I was expecting distclean to bring back the source directory to however it was after checkout, removing anything that might have been created by the build/configure process.

Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-26 Thread Markus Armbruster
Alexandre Raymond cerb...@gmail.com writes: Hi Markus, Well, I'd expect distclean to remove exactly what *this* makefile can build, and leave everything else alone. I was expecting distclean to bring back the source directory to however it was after checkout, removing anything that might

[Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-25 Thread Alexandre Raymond
At the moment, make distclean relies on the TARGET_DIRS variable, set by configure. The problem is that this variable does not always contain all possible targets. For example, the following will leave build data in the tree: ./configure make ./configure --target-list=i386-softmmu \ make