Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-27 Thread Gerd Hoffmann
Hi, +/* open framebuffer */ +if (device == NULL) { +device = getenv(FRAMEBUFFER); +} +if (device == NULL) { +device = /dev/fb0; +} Maybe this is a matter of taste, but I think that having this logic at this layer makes the API harder to use. What

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-27 Thread Luiz Capitulino
On Thu, 27 Jun 2013 11:58:57 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, +/* open framebuffer */ +if (device == NULL) { +device = getenv(FRAMEBUFFER); +} +if (device == NULL) { +device = /dev/fb0; +} Maybe this is a matter of taste,

[Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-26 Thread Gerd Hoffmann
Display works, requires truecolor framebuffer with 16 or 32 bpp on the host. 32bpp is recommended. The framebuffer is used as-is, qemu doesn't try to switch modes. With LCD displays mode switching is pretty pointless IMHO, also it wouldn't work anyway with the most common fbdev drivers (vesafb,

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-12 Thread Gerd Hoffmann
On 06/11/13 08:12, Gerd Hoffmann wrote: Hi, +static QEMUCursor *ptr_cursor; +static pixman_image_t *ptr_image; +static intptr_refresh; +static intpx, py, pw, ph; +static intmx, my, mon; +

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-11 Thread Gerd Hoffmann
Hi, +static QEMUCursor *ptr_cursor; +static pixman_image_t *ptr_image; +static intptr_refresh; +static intpx, py, pw, ph; +static intmx, my, mon; + +/* options */ +static int

[Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-06 Thread Gerd Hoffmann
Display works, requires truecolor framebuffer with 16 or 32 bpp on the host. 32bpp is recommended. The framebuffer is used as-is, qemu doesn't try to switch modes. With LCD displays mode switching is pretty pointless IMHO, also it wouldn't work anyway with the most common fbdev drivers (vesafb,