[Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500

2019-07-14 Thread Rashmica Gupta
GPIO pins are arranged in groups of 8 pins labeled A,B,..,Y,Z,AA,AB,AC. (Note that the ast2400 controller only goes up to group AB). A set has four groups (except set AC which only has one) and is referred to by the groups it is composed of (eg ABCD,EFGH,...,YZAAAB). Each set is accessed and contro

Re: [Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model

2019-07-14 Thread Andrew Jeffery
On Mon, 15 Jul 2019, at 12:06, Rashmica Gupta wrote: > Sorry for the late reply! I agree with most of your feedback and will > send out > a v2 shortly with those changes. I have a few replies below > > [snip] > > > > +static const struct AspeedGPIO gpios[0x1f0] = { > > > +/* Set ABCD */ >

Re: [Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model

2019-07-14 Thread Rashmica Gupta
Sorry for the late reply! I agree with most of your feedback and will send out a v2 shortly with those changes. I have a few replies below [snip] > > +static const struct AspeedGPIO gpios[0x1f0] = { > > +/* Set ABCD */ > > +[GPIO_ABCD_DATA_VALUE] = {0, read_data_value, > > _write_data_val

Re: [Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model

2019-07-02 Thread Andrew Jeffery
On Tue, 18 Jun 2019, at 18:52, Rashmica Gupta wrote: > Add in details for GPIO controller for AST 2400 and 2500 > > Signed-off-by: Rashmica Gupta > --- > hw/gpio/Makefile.objs | 1 + > hw/gpio/aspeed_gpio.c | 869 ++ > include/hw/gpio/aspeed_g

Re: [Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model

2019-06-18 Thread Cédric Le Goater
On 18/06/2019 10:51, Rashmica Gupta wrote: > Add in details for GPIO controller for AST 2400 and 2500 I agree. C. > > Signed-off-by: Rashmica Gupta > --- > hw/gpio/Makefile.objs | 1 + > hw/gpio/aspeed_gpio.c | 869 ++ > include/hw/gpio/aspe

[Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model

2019-06-18 Thread Rashmica Gupta
Add in details for GPIO controller for AST 2400 and 2500 Signed-off-by: Rashmica Gupta --- hw/gpio/Makefile.objs | 1 + hw/gpio/aspeed_gpio.c | 869 ++ include/hw/gpio/aspeed_gpio.h | 76 +++ 3 files changed, 946 insertions(+) create mode 10064