Re: [Qemu-devel] [PATCH 1/2] hw: fw_cfg: refactor fw_cfg_bootsplash()

2018-11-18 Thread 李强
At 2018-11-17 00:33:34, "Markus Armbruster" wrote: >Li Qiang writes: > >> Currently when the splash-time value is bigger than 0x >> we report and correct it, when it is less than 0 we just ingore it. > >s/ingore/ignore/ > >> Also we use qemu_opt_get() to get 'splash-time', then

Re: [Qemu-devel] [PATCH 1/2] hw: fw_cfg: refactor fw_cfg_bootsplash()

2018-11-16 Thread Markus Armbruster
Li Qiang writes: > Currently when the splash-time value is bigger than 0x > we report and correct it, when it is less than 0 we just ingore it. s/ingore/ignore/ > Also we use qemu_opt_get() to get 'splash-time', then convert it to a number > ourselves. This is wrong. Well, doing it that

[Qemu-devel] [PATCH 1/2] hw: fw_cfg: refactor fw_cfg_bootsplash()

2018-11-09 Thread Li Qiang
Currently when the splash-time value is bigger than 0x we report and correct it, when it is less than 0 we just ingore it. Also we use qemu_opt_get() to get 'splash-time', then convert it to a number ourselves. This is wrong. This patch does following: 1. use qemu_opt_get_number() to parse