Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 13:25, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:17, Michael S. Tsirkin m...@redhat.com wrote: Basically the point is that ABI is extended to make ioeventfd with len = 0 mean any

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:25, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:17, Michael S. Tsirkin m...@redhat.com wrote: Basically the point is

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:17, Michael S. Tsirkin m...@redhat.com wrote: Basically the point is that ABI is extended to make ioeventfd with len = 0 mean any length. 0 is thus not meaningless anymore. But how can you do

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Greg Kurz
On Thu, 27 Aug 2015 15:30:55 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:25, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: On 27 August

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Jason Wang
On 08/27/2015 09:10 PM, Greg Kurz wrote: On Thu, 27 Aug 2015 15:30:55 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:25, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:20:52PM

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 05:50, Jason Wang jasow...@redhat.com wrote: On 08/26/2015 10:51 PM, Greg Kurz wrote: On Wed, 26 Aug 2015 15:21:59 +0100 Peter Maydell peter.mayd...@linaro.org wrote: This seems to me like a bug in the caller. Why would anything try to call into the memory subsystem to do

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 11:53, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote: But *why* does it require the size to be zero? I still think the caller should just avoid trying to do zero-size memory operations: they don't make sense. What

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote: On 27 August 2015 at 05:50, Jason Wang jasow...@redhat.com wrote: On 08/26/2015 10:51 PM, Greg Kurz wrote: On Wed, 26 Aug 2015 15:21:59 +0100 Peter Maydell peter.mayd...@linaro.org wrote: This seems to me like a bug in the

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 12:04:49PM +0100, Peter Maydell wrote: On 27 August 2015 at 11:53, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote: But *why* does it require the size to be zero? I still think the caller should just avoid

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 12:08, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 12:04:49PM +0100, Peter Maydell wrote: On 27 August 2015 at 11:53, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote: But *why* does it require

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 01:12:32PM +0100, Peter Maydell wrote: On 27 August 2015 at 12:08, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 12:04:49PM +0100, Peter Maydell wrote: On 27 August 2015 at 11:53, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 13:17, Michael S. Tsirkin m...@redhat.com wrote: Basically the point is that ABI is extended to make ioeventfd with len = 0 mean any length. 0 is thus not meaningless anymore. But how can you do adjustment for incorrect endianness if you don't know the size of the data

[Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-26 Thread Jason Wang
Wildcard mmio eventfd use zero size, but it will lead abort() since it was illegal in adjust_endianness(). Fix this by allowing zero size. Cc: Greg Kurz gk...@linux.vnet.ibm.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Jason Wang jasow...@redhat.com --- memory.c | 1 + 1 file

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-26 Thread Peter Maydell
On 26 August 2015 at 11:04, Jason Wang jasow...@redhat.com wrote: Wildcard mmio eventfd use zero size, but it will lead abort() since it was illegal in adjust_endianness(). Fix this by allowing zero size. Cc: Greg Kurz gk...@linux.vnet.ibm.com Cc: Paolo Bonzini pbonz...@redhat.com

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-26 Thread Greg Kurz
On Wed, 26 Aug 2015 15:21:59 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 26 August 2015 at 11:04, Jason Wang jasow...@redhat.com wrote: Wildcard mmio eventfd use zero size, but it will lead abort() since it was illegal in adjust_endianness(). Fix this by allowing zero size.

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-26 Thread Jason Wang
On 08/26/2015 10:51 PM, Greg Kurz wrote: On Wed, 26 Aug 2015 15:21:59 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 26 August 2015 at 11:04, Jason Wang jasow...@redhat.com wrote: Wildcard mmio eventfd use zero size, but it will lead abort() since it was illegal in