Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: add _filter_qmp_events() for filtering out QMP events

2016-02-11 Thread Sascha Silbe
Dear Eric, Eric Blake writes: >>> tr '\n' '\t' \ >>> | sed -e >>> 's/{\s*"timestamp":\s*{[^}]*},\s*"event":[^,}]*\(,\s*"data":\s*{[^}]*}\)\?\s*}\s*//g' >>> \ >>> | tr '\t' '\n' >> >> Nice trick. Why didn't I come up with it? ;) > > Mishandles any event whose data

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: add _filter_qmp_events() for filtering out QMP events

2016-02-10 Thread Max Reitz
On 09.02.2016 14:23, Sascha Silbe wrote: > The order of some QMP events may depend on the architecture being > tested. Add support for filtering out QMP events so we can use a > single reference output for all architecture when the test doesn't > care about the events. > > Signed-off-by: Sascha

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: add _filter_qmp_events() for filtering out QMP events

2016-02-10 Thread Sascha Silbe
Dear Max, Max Reitz writes: >> +# remove QMP events from output >> +_filter_qmp_events() >> +{ >> +sed -e '/^{\(.*, \)"event": ".*}$/ d' >> +} > > There is a pretty good reason test 067 uses -qmp-pretty (as you yourself > say, the lines get pretty long otherwise, and if

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: add _filter_qmp_events() for filtering out QMP events

2016-02-10 Thread Eric Blake
On 02/10/2016 11:52 AM, Sascha Silbe wrote: > Dear Max, > > Max Reitz writes: > >>> +# remove QMP events from output >>> +_filter_qmp_events() >>> +{ >>> +sed -e '/^{\(.*, \)"event": ".*}$/ d' >>> +} >> >> There is a pretty good reason test 067 uses -qmp-pretty (as you

[Qemu-devel] [PATCH 1/2] qemu-iotests: add _filter_qmp_events() for filtering out QMP events

2016-02-09 Thread Sascha Silbe
The order of some QMP events may depend on the architecture being tested. Add support for filtering out QMP events so we can use a single reference output for all architecture when the test doesn't care about the events. Signed-off-by: Sascha Silbe ---