Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-09 Thread li guang
在 2013-06-06四的 05:48 -0700,Richard Henderson写道: On 06/05/2013 05:28 PM, li guang wrote: 在 2013-06-05三的 05:49 -0700,Richard Henderson写道: On 06/04/2013 06:56 PM, li guang wrote: +typedef struct { +uint32_t len __attribute__((aligned((sizeof(void *); +uint32_t cie_offset; +

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-06 Thread Richard Henderson
On 06/05/2013 05:28 PM, li guang wrote: 在 2013-06-05三的 05:49 -0700,Richard Henderson写道: On 06/04/2013 06:56 PM, li guang wrote: +typedef struct { +uint32_t len __attribute__((aligned((sizeof(void *); +uint32_t cie_offset; +tcg_target_long func_start __attribute__((packed));

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Richard Henderson
On 06/04/2013 06:56 PM, li guang wrote: +typedef struct { +uint32_t len __attribute__((aligned((sizeof(void *); +uint32_t cie_offset; +tcg_target_long func_start __attribute__((packed)); +tcg_target_long func_len __attribute__((packed)); suspicious usage of packed

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Andreas Färber
Am 05.06.2013 14:49, schrieb Richard Henderson: On 06/04/2013 06:56 PM, li guang wrote: +typedef struct { +uint32_t len __attribute__((aligned((sizeof(void *); +uint32_t cie_offset; +tcg_target_long func_start __attribute__((packed)); +tcg_target_long func_len

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Richard Henderson
On 06/05/2013 06:02 AM, Andreas Färber wrote: So why can't you apply QEMU_PACKED to the whole struct? Because of the contradicting void* alignment attribute of the first field? Actually, that might work. I'll give it a shot on x86_64 and change all of the uses if it does work. r~

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Peter Maydell
On 5 June 2013 14:04, Richard Henderson r...@twiddle.net wrote: On 06/05/2013 06:02 AM, Andreas Färber wrote: So why can't you apply QEMU_PACKED to the whole struct? Because of the contradicting void* alignment attribute of the first field? Actually, that might work. I'll give it a shot on

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Richard Henderson
On 06/05/2013 06:10 AM, Peter Maydell wrote: This isn't a big deal except for structs where we care about atomicity, though, which I don't think is the case here. Indeed not. This is just more dwarf debug info for gdb's use. r~

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread li guang
在 2013-06-05三的 05:49 -0700,Richard Henderson写道: On 06/04/2013 06:56 PM, li guang wrote: +typedef struct { +uint32_t len __attribute__((aligned((sizeof(void *); +uint32_t cie_offset; +tcg_target_long func_start __attribute__((packed)); +tcg_target_long func_len

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-04 Thread Richard Henderson
Ping. r~ On 05/24/2013 02:20 PM, Richard Henderson wrote: Allows unwinding past the code_gen_buffer. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 91 ++-- 1 file changed, 82 insertions(+), 9 deletions(-)

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-04 Thread li guang
Hi, Richard, 在 2013-05-24五的 14:20 -0700,Richard Henderson写道: Allows unwinding past the code_gen_buffer. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 91 ++-- 1 file changed, 82 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-05-24 Thread Richard Henderson
Allows unwinding past the code_gen_buffer. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 91 ++-- 1 file changed, 82 insertions(+), 9 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index