Re: [Qemu-devel] [PATCH 1/3] Unified Datagram Socket Transport

2017-07-23 Thread Jason Wang
On 2017年07月22日 01:50, Anton Ivanov wrote: [snip] +NetUnifiedState *s = (NetUnifiedState *) us; +L2TPV3TunnelParams *p = (L2TPV3TunnelParams *) s->params; How about embedding NetUnifiedState into this structure and keep using NetL2TPV3State? Then: - 's' could be kept and lots of

Re: [Qemu-devel] [PATCH 1/3] Unified Datagram Socket Transport

2017-07-21 Thread Anton Ivanov
[snip] +NetUnifiedState *s = (NetUnifiedState *) us; +L2TPV3TunnelParams *p = (L2TPV3TunnelParams *) s->params; How about embedding NetUnifiedState into this structure and keep using NetL2TPV3State? Then: - 's' could be kept and lots of lines of changes could be saved here and l2t

Re: [Qemu-devel] [PATCH 1/3] Unified Datagram Socket Transport

2017-07-18 Thread Anton Ivanov
[snip] Could we keep l2tpv3 option? The l2tpv3 test is actually a test for recvmmsg. If you can do one recvmmsg transport you can do all of them. Yes, but I wonder whether or not the check for recvmmsg is too simple. We probably want something like what AV_VSOCK did, test the support of e

Re: [Qemu-devel] [PATCH 1/3] Unified Datagram Socket Transport

2017-07-18 Thread Jason Wang
On 2017年07月19日 13:48, Anton Ivanov wrote: On 19/07/17 06:39, Jason Wang wrote: On 2017年07月19日 01:08, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov 1. Creates a common backend for socket transports using recvmmsg(). 2. Migrates L2TPv3 to the new backend It would be better i

Re: [Qemu-devel] [PATCH 1/3] Unified Datagram Socket Transport

2017-07-18 Thread Anton Ivanov
On 19/07/17 06:39, Jason Wang wrote: On 2017年07月19日 01:08, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov 1. Creates a common backend for socket transports using recvmmsg(). 2. Migrates L2TPv3 to the new backend It would be better if you could further split out 2 from this pat

Re: [Qemu-devel] [PATCH 1/3] Unified Datagram Socket Transport

2017-07-18 Thread Jason Wang
On 2017年07月19日 01:08, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov 1. Creates a common backend for socket transports using recvmmsg(). 2. Migrates L2TPv3 to the new backend It would be better if you could further split out 2 from this patch. Signed-off-by: Anton Ivanov ---

[Qemu-devel] [PATCH 1/3] Unified Datagram Socket Transport

2017-07-18 Thread anton . ivanov
From: Anton Ivanov 1. Creates a common backend for socket transports using recvmmsg(). 2. Migrates L2TPv3 to the new backend Signed-off-by: Anton Ivanov --- configure | 10 +- net/Makefile.objs | 2 +- net/l2tpv3.c | 531 +- n