Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-22 Thread Dmitry Fleytman
> On 22 Dec 2015, at 11:26 AM, Miao Yan wrote: > > 2015-12-22 17:06 GMT+08:00 P J P : >> +-- On Tue, 22 Dec 2015, Miao Yan wrote --+ >> | > If '1' indicates the error, the 'default:' case in the same switch needs >> to be >> | > updated too. >> | >> |

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-22 Thread P J P
+-- On Tue, 22 Dec 2015, Miao Yan wrote --+ | > If '1' indicates the error, the 'default:' case in the same switch needs to be | > updated too. | | '1' indicates an error on device activation. Not sure about the 'unknown | command' case. Ideally it should be same, inconsistent return codes

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-22 Thread Miao Yan
2015-12-22 17:06 GMT+08:00 P J P : > +-- On Tue, 22 Dec 2015, Miao Yan wrote --+ > | > If '1' indicates the error, the 'default:' case in the same switch needs > to be > | > updated too. > | > | '1' indicates an error on device activation. Not sure about the 'unknown > |

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-21 Thread P J P
+-- On Mon, 21 Dec 2015, Miao Yan wrote --+ | So return 1 on device activation failure instead of -1; | | Signed-off-by: Miao Yan | --- | hw/net/vmxnet3.c | 2 +- | 1 file changed, 1 insertion(+), 1 deletion(-) | | diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c | index

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-21 Thread Miao Yan
2015-12-22 2:15 GMT+08:00 P J P : > +-- On Mon, 21 Dec 2015, Miao Yan wrote --+ > | So return 1 on device activation failure instead of -1; > | > | Signed-off-by: Miao Yan > | --- > | hw/net/vmxnet3.c | 2 +- > | 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-21 Thread Miao Yan
When reading device status, 0 means device is successfully activated and 1 means error. So return 1 on device activation failure instead of -1; Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git