Re: [Qemu-devel] [PATCH 1/3] spapr/pci: Consolidate de-allocation of MSIs

2019-07-27 Thread David Gibson
On Fri, Jul 26, 2019 at 04:44:38PM +0200, Greg Kurz wrote: > When freeing MSIs, we need to: > - remove them from the machine's MSI bitmap > - remove them from the IC backend > - remove them from the PHB's MSI cache > > This is currently open coded in two places in rtas_ibm_change_msi(), > and

Re: [Qemu-devel] [PATCH 1/3] spapr/pci: Consolidate de-allocation of MSIs

2019-07-26 Thread Cédric Le Goater
On 26/07/2019 16:44, Greg Kurz wrote: > When freeing MSIs, we need to: > - remove them from the machine's MSI bitmap > - remove them from the IC backend > - remove them from the PHB's MSI cache > > This is currently open coded in two places in rtas_ibm_change_msi(), > and we're about to need this

[Qemu-devel] [PATCH 1/3] spapr/pci: Consolidate de-allocation of MSIs

2019-07-26 Thread Greg Kurz
When freeing MSIs, we need to: - remove them from the machine's MSI bitmap - remove them from the IC backend - remove them from the PHB's MSI cache This is currently open coded in two places in rtas_ibm_change_msi(), and we're about to need this in spapr_phb_reset() as well. Instead of