Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-04 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: The variable is not written anymore. This cleans up after 9e1c2ec (which accidentally left variable pc_sysfw_flash_vs_rom_bug_compatible behind, value always zero), and buries dead code from commit dafb82e (which looks like it got confused by

Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-04 Thread Markus Armbruster
Jordan Justen jljus...@gmail.com writes: On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini pbonz...@redhat.com wrote: The variable is not written anymore. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/block/pc_sysfw.c | 26 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 11:14, Markus Armbruster ha scritto: The variable is not written anymore. This cleans up after 9e1c2ec (which accidentally left variable pc_sysfw_flash_vs_rom_bug_compatible behind, value always zero), and buries dead code from commit dafb82e (which looks like it got confused

[Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-03 Thread Paolo Bonzini
The variable is not written anymore. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/block/pc_sysfw.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c index 412d1b0..c6d4be4 100644 ---

Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-03 Thread Jordan Justen
On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini pbonz...@redhat.com wrote: The variable is not written anymore. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/block/pc_sysfw.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 22:36, Jordan Justen ha scritto: On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini pbonz...@redhat.com wrote: The variable is not written anymore. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/block/pc_sysfw.c | 26 +- 1 file changed, 1