[Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again again)

2018-03-22 Thread Laurent Vivier
Re-run Coccinelle script scripts/coccinelle/err-bad-newline.cocci, and found new error_report() occurences with '\n'. Signed-off-by: Laurent Vivier --- target/i386/hvf/hvf.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2016-08-05 Thread Markus Armbruster
Eric Blake writes: > On 08/03/2016 05:37 AM, Markus Armbruster wrote: >> Commit 9af9e0f, 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but >> they keep coming back. checkpatch.pl tries to flag them since commit >> 5d596c2, but it's not very good at it. Offenders tracked

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2016-08-04 Thread Eric Blake
On 08/03/2016 05:37 AM, Markus Armbruster wrote: > Commit 9af9e0f, 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but > they keep coming back. checkpatch.pl tries to flag them since commit > 5d596c2, but it's not very good at it. Offenders tracked down with > Coccinelle script

[Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2016-08-03 Thread Markus Armbruster
Commit 9af9e0f, 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they keep coming back. checkpatch.pl tries to flag them since commit 5d596c2, but it's not very good at it. Offenders tracked down with Coccinelle script scripts/coccinelle/err-bad-newline.cocci, an updated version of the

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2015-12-11 Thread Hailiang Zhang
On 2015/12/11 2:16, Cornelia Huck wrote: On Thu, 10 Dec 2015 18:23:49 +0100 Markus Armbruster wrote: Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they keep coming back. Tracked down with the Coccinelle semantic patch from commit 312fd5f. Cc: Fam Zheng

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2015-12-10 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they > keep coming back. Tracked down with the Coccinelle semantic patch > from commit 312fd5f. Reviewed-by: Dr. David Alan Gilbert > Cc: Fam Zheng

[Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2015-12-10 Thread Markus Armbruster
Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they keep coming back. Tracked down with the Coccinelle semantic patch from commit 312fd5f. Cc: Fam Zheng Cc: Peter Crosthwaite Cc: Bharata B Rao Cc: Dominik

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2015-12-10 Thread Bharata B Rao
On Thu, Dec 10, 2015 at 06:23:49PM +0100, Markus Armbruster wrote: > Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they > keep coming back. Tracked down with the Coccinelle semantic patch > from commit 312fd5f. > > Cc: Fam Zheng > Cc: Peter Crosthwaite

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2015-12-10 Thread Cornelia Huck
On Thu, 10 Dec 2015 18:23:49 +0100 Markus Armbruster wrote: > Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they > keep coming back. Tracked down with the Coccinelle semantic patch > from commit 312fd5f. > > Cc: Fam Zheng > Cc: Peter

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2015-12-10 Thread Fam Zheng
On Thu, 12/10 18:23, Markus Armbruster wrote: > diff --git a/block/vmdk.c b/block/vmdk.c > index 6f819e4..b4a224e 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -1494,8 +1494,8 @@ static int vmdk_write(BlockDriverState *bs, int64_t > sector_num, > > if (sector_num >