Re: [Qemu-devel] [PATCH 1/4] hw:i386:pc_piix: split pc_init1()

2014-07-30 Thread Chen, Tiejun
On 2014/7/29 19:26, Michael S. Tsirkin wrote: On Thu, Jul 24, 2014 at 07:30:26PM +0800, Tiejun Chen wrote: We'd like to split pc_init1 and then we can share something with other stuff. Signed-off-by: Tiejun Chen tiejun.c...@intel.com Did you test this patch? It does not look like it can

Re: [Qemu-devel] [PATCH 1/4] hw:i386:pc_piix: split pc_init1()

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 04:19:58PM +0800, Chen, Tiejun wrote: On 2014/7/29 19:26, Michael S. Tsirkin wrote: On Thu, Jul 24, 2014 at 07:30:26PM +0800, Tiejun Chen wrote: We'd like to split pc_init1 and then we can share something with other stuff. Signed-off-by: Tiejun Chen

Re: [Qemu-devel] [PATCH 1/4] hw:i386:pc_piix: split pc_init1()

2014-07-29 Thread Michael S. Tsirkin
On Thu, Jul 24, 2014 at 07:30:26PM +0800, Tiejun Chen wrote: We'd like to split pc_init1 and then we can share something with other stuff. Signed-off-by: Tiejun Chen tiejun.c...@intel.com Did you test this patch? It does not look like it can work. --- hw/i386/pc_piix.c | 93