On 01/24/11 15:50, Chunqiang Tang wrote:
I think the root of the problem is that your series didn't maintain
bisectability.
IOW, each patch needs to be able to be applied one at a time such that
at each point, the build doesn't break and functionality doesn't break.
Otherwise, tools like
I think the root of the problem is that your series didn't maintain
bisectability.
IOW, each patch needs to be able to be applied one at a time such that
at each point, the build doesn't break and functionality doesn't break.
Otherwise, tools like git bisect don't work.
This was true
On 20 January 2011 17:08, Stefan Weil w...@mail.berlios.de wrote:
Yes, that's a problem with some parts of the old code.
For files which you want to modify, you could remove
the spaces with your script before applying your other
modifications and create a separate patch which only
On 01/21/2011 08:51 PM, Chunqiang Tang wrote:
-void qemu_bh_schedule(QEMUBH *bh)
-{
-bh-cb(bh-opaque);
-}
-
-void qemu_bh_cancel(QEMUBH *bh)
-{
-}
-
-void qemu_bh_delete(QEMUBH *bh)
-{
-qemu_free(bh);
-}
-
int qemu_set_fd_handler2(int fd,
IOCanReadHandler
On 20 January 2011 17:08, Stefan Weil w...@mail.berlios.de wrote:
Yes, that's a problem with some parts of the old code.
For files which you want to modify, you could remove
the spaces with your script before applying your other
modifications and create a separate patch which only
removes the
On 01/19/2011 04:04 PM, Chunqiang Tang wrote:
Part 1 of the block device driver for the proposed FVD image format.
Multiple patches are used in order to manage the size of each patch.
This patch includes existing files that are modified by FVD.
See the related discussions at
-void qemu_bh_schedule(QEMUBH *bh)
-{
-bh-cb(bh-opaque);
-}
-
-void qemu_bh_cancel(QEMUBH *bh)
-{
-}
-
-void qemu_bh_delete(QEMUBH *bh)
-{
-qemu_free(bh);
-}
-
int qemu_set_fd_handler2(int fd,
IOCanReadHandler *fd_read_poll,
On Wed, Jan 19, 2011 at 05:04:44PM -0500, Chunqiang Tang wrote:
Part 1 of the block device driver for the proposed FVD image format.
Multiple patches are used in order to manage the size of each patch.
This patch includes existing files that are modified by FVD.
Please try to split the patches
Please try to split the patches into logical parts, and use descriptive
subject lines for each patch.
E.g. adding the new sim command to qemu-io could be one patch, adding
the img_update (why not just update?) command to qemu-img another,
moving code into qemu-tool-time.c one more, etc.
Will
Am 20.01.2011 15:49, schrieb Chunqiang Tang:
Please try to split the patches into logical parts, and use descriptive
subject lines for each patch.
E.g. adding the new sim command to qemu-io could be one patch, adding
the img_update (why not just update?) command to qemu-img another,
moving code
Part 1 of the block device driver for the proposed FVD image format.
Multiple patches are used in order to manage the size of each patch.
This patch includes existing files that are modified by FVD.
See the related discussions at
http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg00426.html
11 matches
Mail list logo
