Re: [Qemu-devel] [PATCH 1/6] gdbstub: Return the fd from gdbserver_start

2018-06-01 Thread Laurent Vivier
Le 01/06/2018 à 00:49, Richard Henderson a écrit : > This will allow us to protect gdbserver_fd from the guest. > > Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 1/6] gdbstub: Return the fd from gdbserver_start

2018-06-01 Thread Richard Henderson
On 06/01/2018 01:59 AM, Peter Maydell wrote: > On 31 May 2018 at 23:49, Richard Henderson > wrote: >> This will allow us to protect gdbserver_fd from the guest. > > Ha, I hadn't realised we already had an internal-to-QEMU filedescriptor :-) Two, in fact, if you count qemu_logfile. ;-) r~

Re: [Qemu-devel] [PATCH 1/6] gdbstub: Return the fd from gdbserver_start

2018-06-01 Thread Philippe Mathieu-Daudé
On 05/31/2018 09:16 PM, Richard Henderson wrote: > On 05/31/2018 04:15 PM, Philippe Mathieu-Daudé wrote: >> Hi Richard, >> >> On 05/31/2018 07:49 PM, Richard Henderson wrote: >>> This will allow us to protect gdbserver_fd from the guest. >>> >>> Signed-off-by: Richard Henderson >>> --- >>> gdbstu

Re: [Qemu-devel] [PATCH 1/6] gdbstub: Return the fd from gdbserver_start

2018-06-01 Thread Peter Maydell
On 31 May 2018 at 23:49, Richard Henderson wrote: > This will allow us to protect gdbserver_fd from the guest. Ha, I hadn't realised we already had an internal-to-QEMU filedescriptor :-) thanks -- PMM

Re: [Qemu-devel] [PATCH 1/6] gdbstub: Return the fd from gdbserver_start

2018-05-31 Thread Richard Henderson
On 05/31/2018 04:15 PM, Philippe Mathieu-Daudé wrote: > Hi Richard, > > On 05/31/2018 07:49 PM, Richard Henderson wrote: >> This will allow us to protect gdbserver_fd from the guest. >> >> Signed-off-by: Richard Henderson >> --- >> gdbstub.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 delet

Re: [Qemu-devel] [PATCH 1/6] gdbstub: Return the fd from gdbserver_start

2018-05-31 Thread Philippe Mathieu-Daudé
Hi Richard, On 05/31/2018 07:49 PM, Richard Henderson wrote: > This will allow us to protect gdbserver_fd from the guest. > > Signed-off-by: Richard Henderson > --- > gdbstub.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 6081e719c

[Qemu-devel] [PATCH 1/6] gdbstub: Return the fd from gdbserver_start

2018-05-31 Thread Richard Henderson
This will allow us to protect gdbserver_fd from the guest. Signed-off-by: Richard Henderson --- gdbstub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 6081e719c5..057d0d65c5 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1890,15 +1890,16 @@ sta