Re: [Qemu-devel] [PATCH 1/7] gluster: Move glfs_close() to create's clean-up

2018-02-13 Thread Eric Blake
On 02/13/2018 07:03 AM, Max Reitz wrote: glfs_close() is a classical clean-up operation, as can be seen by the fact that it is executed even if the truncation before it failed. Also, moving it to clean-up makes it more clear that if it fails, we do not want it to overwrite the current ret value i

[Qemu-devel] [PATCH 1/7] gluster: Move glfs_close() to create's clean-up

2018-02-13 Thread Max Reitz
glfs_close() is a classical clean-up operation, as can be seen by the fact that it is executed even if the truncation before it failed. Also, moving it to clean-up makes it more clear that if it fails, we do not want it to overwrite the current ret value if that signifies an error already. Signed-