Re: [Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start

2016-01-27 Thread Max Reitz
On 25.01.2016 23:05, Daniel P. Berrange wrote: > On Mon, Jan 25, 2016 at 07:41:08PM +0100, Max Reitz wrote: >> Use client_close() if an error in nbd_co_client_start() occurs instead >> of manually inlining parts of it. This fixes an assertion error on the >> server side if nbd_negotiate() fails.

Re: [Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start

2016-01-26 Thread Paolo Bonzini
On 26/01/2016 10:32, Kevin Wolf wrote: > Am 25.01.2016 um 19:41 hat Max Reitz geschrieben: >> > Use client_close() if an error in nbd_co_client_start() occurs instead >> > of manually inlining parts of it. This fixes an assertion error on the >> > server side if nbd_negotiate() fails. >> > >> >

Re: [Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start

2016-01-26 Thread Kevin Wolf
Am 25.01.2016 um 19:41 hat Max Reitz geschrieben: > Use client_close() if an error in nbd_co_client_start() occurs instead > of manually inlining parts of it. This fixes an assertion error on the > server side if nbd_negotiate() fails. > > Signed-off-by: Max Reitz Paolo, if

Re: [Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start

2016-01-25 Thread Eric Blake
On 01/25/2016 11:41 AM, Max Reitz wrote: > Use client_close() if an error in nbd_co_client_start() occurs instead > of manually inlining parts of it. This fixes an assertion error on the > server side if nbd_negotiate() fails. > > Signed-off-by: Max Reitz > --- > nbd/server.c

[Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start

2016-01-25 Thread Max Reitz
Use client_close() if an error in nbd_co_client_start() occurs instead of manually inlining parts of it. This fixes an assertion error on the server side if nbd_negotiate() fails. Signed-off-by: Max Reitz --- nbd/server.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start

2016-01-25 Thread Daniel P. Berrange
On Mon, Jan 25, 2016 at 07:41:08PM +0100, Max Reitz wrote: > Use client_close() if an error in nbd_co_client_start() occurs instead > of manually inlining parts of it. This fixes an assertion error on the > server side if nbd_negotiate() fails. > > Signed-off-by: Max Reitz >