Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-29 Thread Richard Henderson
On 03/29/2016 01:31 AM, Sergey Fedorov wrote: > On 29/03/16 01:12, Richard Henderson wrote: >> On 03/24/2016 08:11 AM, Paolo Bonzini wrote: >>> There is also a case where a TB jumps to itself; it then appears twice >>> in the list with different values in the low bits, such as this: >>> >>>

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-29 Thread Paolo Bonzini
On 29/03/2016 10:14, Paolo Bonzini wrote: > > > On 29/03/2016 00:12, Richard Henderson wrote: >>> There is also a case where a TB jumps to itself; it then appears twice >>> in the list with different values in the low bits, such as this: >>> >>> tb->jmp_list_first = tb | 0; >>>

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-29 Thread Sergey Fedorov
On 29/03/16 01:12, Richard Henderson wrote: > On 03/24/2016 08:11 AM, Paolo Bonzini wrote: >> There is also a case where a TB jumps to itself; it then appears twice >> in the list with different values in the low bits, such as this: >> >> tb->jmp_list_first = tb | 0; >>

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-29 Thread Paolo Bonzini
On 29/03/2016 00:12, Richard Henderson wrote: >> There is also a case where a TB jumps to itself; it then appears twice >> in the list with different values in the low bits, such as this: >> >> tb->jmp_list_first = tb | 0; >> .' | >> |

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-28 Thread Richard Henderson
On 03/24/2016 08:11 AM, Paolo Bonzini wrote: There is also a case where a TB jumps to itself; it then appears twice in the list with different values in the low bits, such as this: tb->jmp_list_first = tb | 0; .' | |.---'

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-24 Thread Alex Bennée
Sergey Fedorov writes: > On 24/03/16 16:42, Alex Bennée wrote: >>> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h >>> > index 05a151da4a54..cc3d2ca25917 100644 >>> > --- a/include/exec/exec-all.h >>> > +++ b/include/exec/exec-all.h >>> > @@ -257,20 +257,32

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-24 Thread Sergey Fedorov
On 24/03/16 16:42, Alex Bennée wrote: >> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h >> > index 05a151da4a54..cc3d2ca25917 100644 >> > --- a/include/exec/exec-all.h >> > +++ b/include/exec/exec-all.h >> > @@ -257,20 +257,32 @@ struct TranslationBlock { >> > struct

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-24 Thread Paolo Bonzini
On 24/03/2016 16:01, Alex Bennée wrote: >>> >> OK I found that tricky to follow. Where does the value of the pointer >>> >> come from that sets these bottom bits? The TB jumping to this TB sets it? > > Where I get confused it what is the point of jmp_list_first? If these > are two circular lists

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-24 Thread Alex Bennée
Paolo Bonzini writes: > On 24/03/2016 16:01, Alex Bennée wrote: >> OK I found that tricky to follow. Where does the value of the pointer >> come from that sets these bottom bits? The TB jumping to this TB sets >> it? >> >> Where I get confused it what is the

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-24 Thread Sergey Fedorov
On 24/03/16 18:01, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 24/03/16 16:42, Alex Bennée wrote: diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h > index 05a151da4a54..cc3d2ca25917 100644 > --- a/include/exec/exec-all.h > +++

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-24 Thread Alex Bennée
sergey.fedo...@linaro.org writes: > From: Sergey Fedorov > > Briefly describe in a comment how direct block chaining is done. It > should help in understanding of the following data fields. > > Rename some fields in TranslationBlock and TCGContext structures to > better

[Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov Briefly describe in a comment how direct block chaining is done. It should help in understanding of the following data fields. Rename some fields in TranslationBlock and TCGContext structures to better reflect their purpose (dropping excessive 'tb_'