Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-12-03 Thread Erik Rull
Paolo Bonzini wrote: On 11/30/2011 10:27 PM, Erik Rull wrote: Erik, if you can test on your Debian 4.0 installation, that would be nice. Thanks! I will do so. Can you provide me a snapshot (.tgz) of the git? I have heard that there are possibilities to create the tgz over some web interfaces

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-12-03 Thread Erik Rull
Paolo Bonzini wrote: On 11/30/2011 10:27 PM, Erik Rull wrote: Erik, if you can test on your Debian 4.0 installation, that would be nice. Thanks! I will do so. Can you provide me a snapshot (.tgz) of the git? I have heard that there are possibilities to create the tgz over some web interfaces

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-12-01 Thread Paolo Bonzini
On 11/30/2011 10:27 PM, Erik Rull wrote: Erik, if you can test on your Debian 4.0 installation, that would be nice. Thanks! I will do so. Can you provide me a snapshot (.tgz) of the git? I have heard that there are possibilities to create the tgz over some web interfaces of git, but I didn't

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-30 Thread Erik Rull
Paolo Bonzini wrote: On 11/28/2011 11:36 PM, Anthony Liguori wrote: Hrm, I may have messed this up. My mailbox processing script seems to have found Aneesh's patch instead of Paolo's. Can ya'll take a look at 2507718baf311ea78156c6777d38410a9f89ce89 and tell me if I need to revert it? No,

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-29 Thread Paolo Bonzini
On 11/28/2011 11:36 PM, Anthony Liguori wrote: Hrm, I may have messed this up. My mailbox processing script seems to have found Aneesh's patch instead of Paolo's. Can ya'll take a look at 2507718baf311ea78156c6777d38410a9f89ce89 and tell me if I need to revert it? No, qemu.git master is

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-29 Thread Aneesh Kumar K.V
On Mon, 28 Nov 2011 16:36:18 -0600, Anthony Liguori anth...@codemonkey.ws wrote: On 11/23/2011 12:16 AM, Aneesh Kumar K.V wrote: On Mon, 21 Nov 2011 09:29:11 +0100, Paolo Bonzinipbonz...@redhat.com wrote: Small requirements on new features have percolated to virtio-9p-local.c. In

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-28 Thread Anthony Liguori
On 11/23/2011 12:16 AM, Aneesh Kumar K.V wrote: On Mon, 21 Nov 2011 09:29:11 +0100, Paolo Bonzinipbonz...@redhat.com wrote: Small requirements on new features have percolated to virtio-9p-local.c. In particular, the utimensat wrapper actually only supports dirfd = AT_FDCWD and flags =

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-23 Thread Aneesh Kumar K.V
On Wed, 23 Nov 2011 08:24:53 +0100, Paolo Bonzini pbonz...@redhat.com wrote: On 11/23/2011 07:16 AM, Aneesh Kumar K.V wrote: We would also require same changes for virtio-9p-handle.c right ? virtio-9p-handle.c is only for recent Linux and you can assume the ioctl is defined there. But the

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-23 Thread Paolo Bonzini
On 11/23/2011 04:11 PM, Aneesh Kumar K.V wrote: virtio-9p-handle.c is only for recent Linux and you can assume the ioctl is defined there. But the file gets build by default right ? ie, we would build virtio-9p-handle.c and if FS_IOC_GETVERSION is not defined, build will fail right ? I

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-22 Thread Aneesh Kumar K.V
On Mon, 21 Nov 2011 09:29:11 +0100, Paolo Bonzini pbonz...@redhat.com wrote: Small requirements on new features have percolated to virtio-9p-local.c. In particular, the utimensat wrapper actually only supports dirfd = AT_FDCWD and flags = AT_SYMLINK_NOFOLLOW in the fallback code. Remove the

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-22 Thread Paolo Bonzini
On 11/23/2011 07:16 AM, Aneesh Kumar K.V wrote: We would also require same changes for virtio-9p-handle.c right ? virtio-9p-handle.c is only for recent Linux and you can assume the ioctl is defined there. Paolo

[Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-21 Thread Paolo Bonzini
Small requirements on new features have percolated to virtio-9p-local.c. In particular, the utimensat wrapper actually only supports dirfd = AT_FDCWD and flags = AT_SYMLINK_NOFOLLOW in the fallback code. Remove the arguments so that virtio-9p-local.c will not use AT_* constants. At the same

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-21 Thread Anthony Liguori
On 11/21/2011 02:29 AM, Paolo Bonzini wrote: Small requirements on new features have percolated to virtio-9p-local.c. In particular, the utimensat wrapper actually only supports dirfd = AT_FDCWD and flags = AT_SYMLINK_NOFOLLOW in the fallback code. Remove the arguments so that virtio-9p-local.c

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-21 Thread Paolo Bonzini
On 11/21/2011 10:01 PM, Anthony Liguori wrote: -return qemu_utimensat(AT_FDCWD, rpath(s, path, buffer), buf, - AT_SYMLINK_NOFOLLOW); +return qemu_utimens(rpath(s, path, buffer), buf); Hrm, I thought the SYMLINK_NOFOLLOW was critical in enforcing security?