Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-05 Thread Peter Maydell
On 4 June 2016 at 23:33, Richard Henderson wrote: > On 06/04/2016 11:34 AM, Michael Rolnik wrote: >> >> understood. but I am totally lost now. what should I do now. >> I've sent a set of patches last Friday, they should include all the fixes. > > > For the next round: > > git format-patch --cove

Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-04 Thread Richard Henderson
On 06/02/2016 01:07 PM, Michael Rolnik wrote: Signed-off-by: Michael Rolnik --- target-avr/cpu-qom.h| 38 + target-avr/cpu.c| 100 +--- target-avr/cpu.h| 74 target-avr/gdb

Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-04 Thread Richard Henderson
On 06/04/2016 11:34 AM, Michael Rolnik wrote: understood. but I am totally lost now. what should I do now. I've sent a set of patches last Friday, they should include all the fixes. For the next round: git format-patch --cover-letter --subject-prefix='PATCH v4' master Edit -cover-letter

Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-04 Thread Michael Rolnik
understood. but I am totally lost now. what should I do now. I've sent a set of patches last Friday, they should include all the fixes. Michael On Sat, Jun 4, 2016 at 8:41 PM, Richard Henderson wrote: > On 06/02/2016 04:10 PM, Peter Maydell wrote: > >> PS: it would be good if you could provide

Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-04 Thread Richard Henderson
On 06/02/2016 04:10 PM, Peter Maydell wrote: PS: it would be good if you could provide a cover letter when you send out the next round of these patches; that provides a handy way to deal with the series as a whole (for both automated tools and people), so we tend to prefer multi-patch sets to hav

Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-02 Thread Peter Maydell
On 2 June 2016 at 21:07, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > target-avr/cpu-qom.h| 38 + > target-avr/cpu.c| 100 > +--- > target-avr/cpu.h| 74 >

[Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu-qom.h| 38 + target-avr/cpu.c| 100 +--- target-avr/cpu.h| 74 target-avr/gdbstub.c| 10 + target-avr/helper.c

[Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu-qom.h| 38 + target-avr/cpu.c| 100 +--- target-avr/cpu.h| 74 target-avr/gdbstub.c| 10 + target-avr/helper.c