Re: [Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Hervé Poussineau
Le 10/12/2015 11:29, Markus Armbruster a écrit : isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when passed a null bus. Use of hw_error() has always been questionable, because these are used only during machine initialization, and printing CPU registers isn't useful there.

[Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Markus Armbruster
isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when passed a null bus. Use of hw_error() has always been questionable, because these are used only during machine initialization, and printing CPU registers isn't useful there. Since the previous commit, passing a null bus is a

Re: [Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 12:29 PM, Markus Armbruster wrote: isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when passed a null bus. Use of hw_error() has always been questionable, because these are used only during machine initialization, and printing CPU registers isn't useful there.

Re: [Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 12/10/2015 12:29 PM, Markus Armbruster wrote: >> isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when >> passed a null bus. Use of hw_error() has always been questionable, >> because these are used only during machine

Re: [Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 03:09 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: On 12/10/2015 12:29 PM, Markus Armbruster wrote: isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when passed a null bus. Use of hw_error() has always been questionable,