Re: [Qemu-devel] [PATCH 10/15] apb: remove pci_apb_init() and instantiate APB device using qdev

2017-11-20 Thread Mark Cave-Ayland
On 20/11/17 17:51, Philippe Mathieu-Daudé wrote: > Hi Mark, > > On 11/17/2017 10:42 AM, Mark Cave-Ayland wrote: >> By making the special_base and mem_base values qdev properties, we can move >> the remaining parts of pci_apb_init() into the pbm init() and realize() >> functions. >> >> This

Re: [Qemu-devel] [PATCH 10/15] apb: remove pci_apb_init() and instantiate APB device using qdev

2017-11-20 Thread Philippe Mathieu-Daudé
Hi Mark, On 11/17/2017 10:42 AM, Mark Cave-Ayland wrote: > By making the special_base and mem_base values qdev properties, we can move > the remaining parts of pci_apb_init() into the pbm init() and realize() > functions. > > This finally allows us to instantiate the APB directly using standard

Re: [Qemu-devel] [PATCH 10/15] apb: remove pci_apb_init() and instantiate APB device using qdev

2017-11-17 Thread Artyom Tarasenko
On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland wrote: > By making the special_base and mem_base values qdev properties, we can move > the remaining parts of pci_apb_init() into the pbm init() and realize() > functions. > > This finally allows us to instantiate

[Qemu-devel] [PATCH 10/15] apb: remove pci_apb_init() and instantiate APB device using qdev

2017-11-17 Thread Mark Cave-Ayland
By making the special_base and mem_base values qdev properties, we can move the remaining parts of pci_apb_init() into the pbm init() and realize() functions. This finally allows us to instantiate the APB directly using standard qdev create/init functions in sun4u.c. Signed-off-by: Mark