On 08/10/2018 19:31, Markus Armbruster wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. smbios_entry_add() does that, and then exit()s. It
> also passes _fatal to qemu_opts_validate(). Both wrong, but
> currently harmless, as its only caller passes
Hi
On Mon, Oct 8, 2018 at 9:47 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. smbios_entry_add() does that, and then exit()s. It
> also passes _fatal to qemu_opts_validate(). Both wrong, but
> currently harmless, as its
Calling error_report() in a function that takes an Error ** argument
is suspicious. smbios_entry_add() does that, and then exit()s. It
also passes _fatal to qemu_opts_validate(). Both wrong, but
currently harmless, as its only caller passes _fatal. Messed up
in commit 1007a37e208. Clean it
