Re: Making QMP self-documenting (was: [Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.)

2010-01-13 Thread Luiz Capitulino
On Tue, 12 Jan 2010 19:57:29 +0100 Markus Armbruster arm...@redhat.com wrote: Here's my stab at self-documenting commands. We need to describe the request, the reply, and possible errors. First the request part. Its format according to qemu-spec.txt is: { execute: json-string, arguments:

Re: [Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.

2010-01-12 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Tue, 29 Dec 2009 19:25:24 + Nathan Baum nat...@parenthephobia.org.uk wrote: On Tue, 2009-12-29 at 15:15 -0200, Luiz Capitulino wrote: On Sat, 26 Dec 2009 21:19:22 + Nathan Baum nat...@parenthephobia.org.uk wrote:

Re: [Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.

2010-01-12 Thread Luiz Capitulino
On Tue, 12 Jan 2010 09:25:05 +0100 Markus Armbruster arm...@redhat.com wrote: We were considering something along these lines but we didn't consider having the description as part of the dict, for example. We did, actually :) That's good then! This solves

Making QMP self-documenting (was: [Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.)

2010-01-12 Thread Markus Armbruster
I'd like to make QMP self-documenting, i.e. make documentation available within QMP, in structured form, so that clients can discover available capabilities, commands, their arguments, possible responses and errors, and so forth. The core protocol is outside the scope of self-documentation. By

Re: [Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.

2009-12-29 Thread Luiz Capitulino
On Sat, 26 Dec 2009 21:19:22 + Nathan Baum nat...@parenthephobia.org.uk wrote: Signed-off-by: Nathan Baum nat...@parenthephobia.org.uk --- hw/qdev.c |9 - hw/qdev.h |3 ++- monitor.c |3 ++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/qdev.c

Re: [Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.

2009-12-29 Thread Nathan Baum
On Tue, 2009-12-29 at 15:15 -0200, Luiz Capitulino wrote: On Sat, 26 Dec 2009 21:19:22 + Nathan Baum nat...@parenthephobia.org.uk wrote: Signed-off-by: Nathan Baum nat...@parenthephobia.org.uk --- hw/qdev.c |9 - hw/qdev.h |3 ++- monitor.c |3 ++- 3 files

Re: [Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.

2009-12-29 Thread Luiz Capitulino
On Tue, 29 Dec 2009 19:25:24 + Nathan Baum nat...@parenthephobia.org.uk wrote: On Tue, 2009-12-29 at 15:15 -0200, Luiz Capitulino wrote: On Sat, 26 Dec 2009 21:19:22 + Nathan Baum nat...@parenthephobia.org.uk wrote: Signed-off-by: Nathan Baum nat...@parenthephobia.org.uk ---

[Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum nat...@parenthephobia.org.uk --- hw/qdev.c |9 - hw/qdev.h |3 ++- monitor.c |3 ++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index f5d68c6..d9d3778 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -727,6 +727,12