Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-08-11 Thread Blue Swirl
Thanks, applied. On Wed, Jul 18, 2012 at 2:10 PM, Peter Maydell peter.mayd...@linaro.org wrote: Add support for checking whether test case code can compile without warnings, by recompiling each successful test with -Werror. If the -Werror version doesn't pass, we bail out. This gives us the

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-08-09 Thread Peter Maydell
On 4 August 2012 18:57, Blue Swirl blauwir...@gmail.com wrote: On Sat, Jul 28, 2012 at 1:48 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 July 2012 13:31, Blue Swirl blauwir...@gmail.com wrote: I'm getting this error, probably because now Valgrind support is enabled: CC

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 6:24 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 4 August 2012 18:57, Blue Swirl blauwir...@gmail.com wrote: On Sat, Jul 28, 2012 at 1:48 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 July 2012 13:31, Blue Swirl blauwir...@gmail.com wrote: I'm

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-08-04 Thread Blue Swirl
On Sat, Jul 28, 2012 at 1:48 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 July 2012 13:31, Blue Swirl blauwir...@gmail.com wrote: I'm getting this error, probably because now Valgrind support is enabled: CCcoroutine-ucontext.o cc1: warnings being treated as errors

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-07-28 Thread Blue Swirl
On Wed, Jul 18, 2012 at 2:10 PM, Peter Maydell peter.mayd...@linaro.org wrote: Add support for checking whether test case code can compile without warnings, by recompiling each successful test with -Werror. If the -Werror version doesn't pass, we bail out. This gives us the same level of

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-07-28 Thread Peter Maydell
On 28 July 2012 10:04, Blue Swirl blauwir...@gmail.com wrote: On Wed, Jul 18, 2012 at 2:10 PM, Peter Maydell peter.mayd...@linaro.org wrote: +echo ERROR: configure test passed without -Werror but failed with -Werror. +echo This is probably a bug in the configure script. The failing

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-07-28 Thread Blue Swirl
On Sat, Jul 28, 2012 at 10:57 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 July 2012 10:04, Blue Swirl blauwir...@gmail.com wrote: On Wed, Jul 18, 2012 at 2:10 PM, Peter Maydell peter.mayd...@linaro.org wrote: +echo ERROR: configure test passed without -Werror but failed with

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-07-28 Thread Peter Maydell
On 28 July 2012 13:09, Blue Swirl blauwir...@gmail.com wrote: On Sat, Jul 28, 2012 at 10:57 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 July 2012 10:04, Blue Swirl blauwir...@gmail.com wrote: , I'm getting configure breakage in some cases: The thesis of the patch series is that

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-07-28 Thread Blue Swirl
On Sat, Jul 28, 2012 at 12:14 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 July 2012 13:09, Blue Swirl blauwir...@gmail.com wrote: On Sat, Jul 28, 2012 at 10:57 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 July 2012 10:04, Blue Swirl blauwir...@gmail.com wrote: , I'm

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-07-28 Thread Blue Swirl
On Sat, Jul 28, 2012 at 12:14 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 July 2012 13:09, Blue Swirl blauwir...@gmail.com wrote: On Sat, Jul 28, 2012 at 10:57 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 July 2012 10:04, Blue Swirl blauwir...@gmail.com wrote: , I'm

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-07-28 Thread Peter Maydell
On 28 July 2012 13:31, Blue Swirl blauwir...@gmail.com wrote: I'm getting this error, probably because now Valgrind support is enabled: CCcoroutine-ucontext.o cc1: warnings being treated as errors /src/qemu/coroutine-ucontext.c:204: error: unknown option after '#pragma GCC diagnostic'

[Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-07-18 Thread Peter Maydell
Add support for checking whether test case code can compile without warnings, by recompiling each successful test with -Werror. If the -Werror version doesn't pass, we bail out. This gives us the same level of visibility of warnings in test code as --enable-werror provides for the main compile.