Re: [Qemu-devel] [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState

2011-03-23 Thread Stefan Hajnoczi
On Wed, Mar 23, 2011 at 12:16 AM, Anthony Liguori aligu...@us.ibm.com wrote: +static QObject *read_current_schema(void) +{ +    char buffer[65536]; +    int fd; +    int ret; +    size_t offset = 0; +    ssize_t len; + +    ret = system(i386-softmmu/qemu -vmstate-dump /tmp/schema.json);

Re: [Qemu-devel] [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState

2011-03-23 Thread Peter Maydell
On 23 March 2011 00:16, Anthony Liguori aligu...@us.ibm.com wrote: +    if (old_version != new_version) { +        g_error(Version %d of device `%s' is available in QEMU, but schema still reports %d, please update schema.\n, +                new_version, device, old_version); +    } Might

Re: [Qemu-devel] [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState

2011-03-23 Thread Anthony Liguori
On 03/23/2011 05:22 AM, Peter Maydell wrote: On 23 March 2011 00:16, Anthony Liguorialigu...@us.ibm.com wrote: +if (old_version != new_version) { +g_error(Version %d of device `%s' is available in QEMU, but schema still reports %d, please update schema.\n, +

[Qemu-devel] [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState

2011-03-22 Thread Anthony Liguori
We've had lots of issues surrounding live migration breaking. This is because we haven't had a good way to validate that what we're migrating isn't changing underneath of us. This test works by first converting the in-tree schema to C source as a string. This is built into the test case. The

Re: [Qemu-devel] [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState

2011-03-22 Thread Anthony Liguori
On 03/22/2011 07:16 PM, Anthony Liguori wrote: We've had lots of issues surrounding live migration breaking. This is because we haven't had a good way to validate that what we're migrating isn't changing underneath of us. This test works by first converting the in-tree schema to C source as a