Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-08-01 Thread Paolo Bonzini
Il 01/08/2014 09:35, Ming Lei ha scritto: > OK, I will convert non-dataplane to support multi virtqueues in V1, > and the conversion is not difficult and straightforward. > > BTW, docs/migration.txt mentions that "QEMU has to be launched > with the same arguments the two times", so can I understan

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-08-01 Thread Ming Lei
On Fri, Aug 1, 2014 at 2:10 PM, Paolo Bonzini wrote: > Il 01/08/2014 05:09, Ming Lei ha scritto: >> Per virtio spec, only the feature is set, the VM can be allowed to >> access the 'num_queues' field, and I didn't see any problem from >> VM's view point. >> >> So could you

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-31 Thread Paolo Bonzini
Il 01/08/2014 05:09, Ming Lei ha scritto: >>> >> Per virtio spec, only the feature is set, the VM can be allowed to >>> >> access the 'num_queues' field, and I didn't see any problem from >>> >> VM's view point. >>> >> >>> >> So could you explain why both dataplane and non-dataplane have >>> >> to

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-31 Thread Ming Lei
On Fri, Aug 1, 2014 at 11:09 AM, Ming Lei wrote: > On Thu, Jul 31, 2014 at 4:52 PM, Paolo Bonzini wrote: >> >> It doesn't matter, changing features between dataplane and non-dataplane >> is not something that you can do. > > Actually it is easy to support multi virtqueue for non-dataplane, > and

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-31 Thread Ming Lei
On Thu, Jul 31, 2014 at 4:52 PM, Paolo Bonzini wrote: > Il 31/07/2014 05:47, Ming Lei ha scritto: >> On Wed, Jul 30, 2014 at 11:25 PM, Paolo Bonzini wrote: >>> Il 30/07/2014 17:12, Michael S. Tsirkin ha scritto: >> >> Dataplane must not be a change to the guest ABI. If you implement this

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 05:47, Ming Lei ha scritto: > On Wed, Jul 30, 2014 at 11:25 PM, Paolo Bonzini wrote: >> Il 30/07/2014 17:12, Michael S. Tsirkin ha scritto: > > Dataplane must not be a change to the guest ABI. If you implement this > feature you have to implement it for both dataplane an

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-30 Thread Ming Lei
On Wed, Jul 30, 2014 at 11:25 PM, Paolo Bonzini wrote: > Il 30/07/2014 17:12, Michael S. Tsirkin ha scritto: >>> > >>> > Dataplane must not be a change to the guest ABI. If you implement this >>> > feature you have to implement it for both dataplane and non-dataplne. >>> > IMO, no matter if the

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-30 Thread Paolo Bonzini
Il 30/07/2014 17:12, Michael S. Tsirkin ha scritto: >> > >> > Dataplane must not be a change to the guest ABI. If you implement this >> > feature you have to implement it for both dataplane and non-dataplne. >> > >> > Paolo > Actually, I think different backends at runtime should be allowed to >

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 04:01:59PM +0200, Paolo Bonzini wrote: > Il 30/07/2014 13:39, Ming Lei ha scritto: > > Now we only support multi vqs for dataplane case. > > > > Signed-off-by: Ming Lei > > --- > > hw/block/virtio-blk.c | 18 +- > > include/hw/virtio/virtio-blk.

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-30 Thread Paolo Bonzini
Il 30/07/2014 13:39, Ming Lei ha scritto: > Now we only support multi vqs for dataplane case. > > Signed-off-by: Ming Lei > --- > hw/block/virtio-blk.c | 18 +- > include/hw/virtio/virtio-blk.h |1 + > 2 files changed, 18 insertions(+), 1 deletion(-) > > diff --gi

[Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-30 Thread Ming Lei
Now we only support multi vqs for dataplane case. Signed-off-by: Ming Lei --- hw/block/virtio-blk.c | 18 +- include/hw/virtio/virtio-blk.h |1 + 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index ab99